Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brighter color for charts axis and ticks would improve readability #1375

Closed
ehorvat1 opened this issue Oct 3, 2024 · 0 comments
Closed

Brighter color for charts axis and ticks would improve readability #1375

ehorvat1 opened this issue Oct 3, 2024 · 0 comments

Comments

@ehorvat1
Copy link
Contributor

ehorvat1 commented Oct 3, 2024

Charts are a great feature, thanks.

A brighter color for charts axis and ticks would improve readability
Currently the text/labels for axes and ticks are quite dark and therefore hard to read on a dark canvas.

This could be improved by adding : Chart.defaults.color = '#99' to the drv_charts.c file.
I will send a pull request for this .
Rg, Bert
ehorvat1 added a commit to ehorvat1/OpenBK7231T_App_incl_Charts that referenced this issue Oct 3, 2024
@ehorvat1
Update drv_charts.c Issue openshwprojects#1375
47f76a4 
For issue openshwprojects#1375: add a default color to improve readability (applies to: dataset names, axis ticks, color for axes title, (use color: 'openshwprojects#99')
@ehorvat1 ehorvat1 mentioned this issue Oct 3, 2024
Merged
openshwprojects pushed a commit that referenced this issue Oct 3, 2024
@ehorvat1
Fix issue #1375 and #1376 (#1377)
52efa43 
* Fix issue #1376

Fix issue #1376 .....wrong time in charts when using NTP with an offset

* Update drv_charts.c  Issue #1375

For issue #1375: add a default color to improve readability (applies to: dataset names, axis ticks, color for axes title, (use color: '#99')

* Update drv_charts.c

Add a chart title

* Update obk_config.h

Set ENABLE_DRIVER_CHARTS = 1 also for Beken Devices

* Update http_fns.c

Add charts to About page

* Update obk_config.h

File just cloned from openshwprojects/OpenBK7231T_App

* Revert "Update obk_config.h"

This reverts commit b83c7db.

* Revert "Update obk_config.h"

This reverts commit 7b7d979.

* Revert "Update http_fns.c"

This reverts commit d81e4b3.

* Revert "Update drv_charts.c"

This reverts commit c5d1229.
@ehorvat1 ehorvat1 closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ehorvat1