Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

My Space List: API adjustments needed for sorting/filtering and additional data needed #1849

Open
dgutride opened this issue Jan 10, 2018 · 3 comments

Comments

@dgutride
Copy link
Collaborator

dgutride commented Jan 10, 2018

This is an issue to roll up all of the others that have been entered around this and provide a higher level overview of what is needed. Only the my spaces page is impacted - all spaces is still under discussion as to whether or not it will be in the product long term.

Design: https://redhat.invisionapp.com/share/DQDSL22JA#/screens/261389228

API needs:
Filtering/searching/sorting
The page needs to be able to support sorting and filtering either client or server side. Although paging is supported now, we can't sort or filter this way because only the paged entries would be impacted instead of the entire list. This is a must have for GA on the columns we agree to include (some are still at risk like activity and private).

Sorting columns: Activity, Name
Filtering: Activity, Collaborator, Name, Owner, Private

Existing issues:

Additional data needed:
The space list includes additional data that is not available today:

  1. User relationship to the space - owner, collaborator, none - must have for GA so user can take appropriate actions if any (leave space for collaborator, delete space for owner)
  2. Activity - algorithm still to be determined, need to discuss if this is priority
  3. Private - is this required for GA?

Existing issues:

@joshuawilson @catrobson @dlabrecq @aslakknutsen

@dgutride dgutride changed the title Space List: API adjustments needed for sorting/filtering and additional data needed My Space List: API adjustments needed for sorting/filtering and additional data needed Jan 10, 2018
@joshuawilson joshuawilson added this to the Platform Backlog milestone Jan 10, 2018
@joshuawilson
Copy link
Member

After talking with @qodfathr he confirmed that the things we already support can be implemented. Whereas things like private spaces don't exist and we will not be adding it.

@catrobson
Copy link
Collaborator

@joshuawilson can you expand on this a little bit for what exactly you expect this means?

  • Does this mean that we will not show a list of both owner and collaborator spaces? This felt like MVP need to me.
  • Does this mean we will not support any sort of filtering on the page?
  • Does this mean we will not support any sort of sorting on the page?

Activity and Private spaces not being included for GA is reasonable to me.

@qodfathr
Copy link
Collaborator

If we have an API which can provide the necessary data, we will use it.
If we don't have an API, the API should be considered to be a stretch goal for H.
So, "will we show a list of both owner and collaborator" will have the same answer as "do we have an API which provides list of Spaces and, either in the API itself or easily on the front end, that list can be classified between owner and collaborator."

Filtering strikes me as a front-end capability (assuming the returned data is of a reasonable size), so the hope is that the Patternfly gadgets used essentially provide this capability for free.

Note that "data is of a reasonable size" implies that the API is only returning Spaces directly associated to the user (either as owner or collaborator) and does not include every Space in the system, across all users. That would require filtering to be done in the backend. If that capability is not currently in the backend, it's a stretch goal to add it.

The same approach should apply to sorting: reasonable sized data returned, front-end operation, already a part of the Patternfly.

Does that help? We are definitely in "make hard decisions and cut stuff" mode right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants