-
Notifications
You must be signed in to change notification settings - Fork 66
API: Need expanded delete space functionality #1746
Comments
Openshift resources are easy enough assuming all the labeling matches(I think the route is missing it atm), but just that would leave GitHub repos with orphan webhooks as well as Che workspaces referring the codebases. |
Also, the Deployments API supports deletion of deployments in Openshift. It could be used as a reference, or directly to assist with this. This begins at: |
Following up on the API Jie pointed out, currently this deletes the following for a deployment (an application within one environment):
We could expand on this to support deleting a whole application across environments, or all applications within a space. |
Sounds like this might move us along faster, thanks. |
From the UI point of view Delete space should be enough. The rest should be orchestrated internally |
I agree. However, the current design has delete/remove on several components including Deployments. I want to confirm that you are NOT commenting on that functionality. |
@joshuawilson Not sure I understand your comment. Multiple objects or not, the UI shouldn't care. The action the UI care about is Delete space. |
I was referencing "The rest should be orchestrated internally" comment. Just to make sure you didn't want the functionality removed from the UI components that delete parts. I didn't think you did, just confirming. |
Should the UI be able to Delete a single Deployment? yes |
Agreed. :) |
…ace (#1966) When a space is deleted also delete codebases associated with it and after that delete the OpenShift resources consumed by the space. Fixes openshiftio/openshift.io#1746
Before when codebases were deleted we were only checking if the return code is 200. But the codebase deletion API returns 204 or No content. So this commit fixes that, by adding a check for all return code from 200 to 299. Related to openshiftio/openshift.io#1746
…ace (#1966) When a space is deleted also delete codebases associated with it and after that delete the OpenShift resources consumed by the space. Fixes openshiftio/openshift.io#1746
Goal would be to have a DELETE /api/spaces/{id} to support UI in this story:
fabric8-ui/fabric8-ux#610
Delete should not just delete the space from the platform database, all labeled space entries on openshift should also be removed so we don't orphan entries.
Internally call:
Long term:
The text was updated successfully, but these errors were encountered: