Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

"Reset Environment" should cleanup custom tenant config #1049

Open
ibuziuk opened this issue Oct 3, 2017 · 13 comments
Open

"Reset Environment" should cleanup custom tenant config #1049

ibuziuk opened this issue Oct 3, 2017 · 13 comments

Comments

@ibuziuk
Copy link
Collaborator

ibuziuk commented Oct 3, 2017

fabric8 PR verification is a super cool feature and everyone can test new version of tenant by navigating to URL e.g. [1] and pushing "Save and Update Tenant" button. However, resetting this configuration is not very straight forward - one should navigate to the profile tenant page [2] and push "Clear Values" button.
At very least "Reset Environment" from profile page should also do custom tenant config cleanup.

[1] https://openshift.io/_profile/_tenant?cheVersion=PR-v8fa786e-12&mavenRepo=https://nexus.cd.test.fabric8.io/content/repositories/staging
[2] https://openshift.io/_profile/_tenant

Parent Experience

#2156 Tenant Override Screen placeholder

@benoitf
Copy link
Collaborator

benoitf commented Oct 4, 2017

I faced the same issue, I was expecting that reset env button was also clearing up all tenant config but it was not the case.

@joshuawilson
Copy link
Member

@ibuziuk what are you asking for? Are you asking for some UX on this back door?

@ibuziuk
Copy link
Collaborator Author

ibuziuk commented Nov 27, 2017

@joshuawilson it is a back door currently and some trivial back-end validation of maven repo / checksum for sure must be in place

@joshuawilson
Copy link
Member

I think I misunderstood the first time. @ibuziuk we should talk to @catrobson about designing a better user flow for this page.

@qodfathr
Copy link
Collaborator

Is this still an issue? Our goal is to remove the need for the "Reset Environment" button. Is this mainly serving an internal need?

@joshuawilson
Copy link
Member

I think we should consider keeping this. On the free tier the user may want to play around and then reset. I reset just to clean up so I don't have to do it manually.

@ldimaggi
Copy link
Collaborator

ldimaggi commented Jan 23, 2018 via email

@qodfathr
Copy link
Collaborator

Okay, now I'm even more confused. :)

Are we saying that this issue needs to be addressed directly?
Are we saying that the Reset Env button should not go away?
Are we saying this is all moot because the Reset Env button is going to go away?

Personally, I really want to see the Reset Env button go away. IMHO, it's existence is being used crutch to avoid fixing bugs. I never enjoy having to push that button, especially now that I have dozens of Spaces.

If the original request of this Issue is serving an internal-need only, then I'd prefer to see us adopt an internal only solution (e.g. perhaps the Reset Env button is Feature Flagged to be Internal or we have and additional internal-only button which can address this particular issue.)

@aslakknutsen
Copy link
Collaborator

aslakknutsen commented Jan 28, 2018

@qodfathr Agree that this feature should be hidden from normal usage. It's to destructive during normal usage of the system, and really only valuable for test envs or test users. The users need for this will go away when Space:Delete takes OSO space related resources into account on Delete: #1746

But, to @ibuziuk's point; 'Should it also remove tenant overrides set on the account?", I think if we move "Reset Env" to the "Tenant override page" and away from the "User Profile Edit", then it would become clearer what you are Resetting the env to as you can see the Override set on the same screen.

@qodfathr
Copy link
Collaborator

@aslakknutsen are you suggesting a new Tenant Override page? Or is that some hidden thing that already exists? Regardless, I agree with the value for the scenarios you described.

@ldimaggi
Copy link
Collaborator

I'm fine with the feature being hidden - but it should not be removed. Users, especially new users, and users experimenting with OSIO will require access to a cleaned environment.

@aslakknutsen
Copy link
Collaborator

aslakknutsen commented Jan 29, 2018

@qodfathr It's a thing that exists, but usage is restricted to 'Internal'.

@sthaha
Copy link
Collaborator

sthaha commented Jul 30, 2018

Removing team/build-cd since it doesn't seem like an issue related to build. Additionally this feature request must be tracked in Planner

@sthaha sthaha removed their assignment Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants