Skip to content

AGENT-992: installer presubmit job to test control plane with 4 and 5 replicas #58621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 15, 2024
Merged

AGENT-992: installer presubmit job to test control plane with 4 and 5 replicas #58621

openshift-merge-bot merged 1 commit into from
Nov 15, 2024

Conversation

@rwsu
Copy link
Contributor

@rwsu rwsu commented Nov 7, 2024 •
edited
Loading

The job's name is e2e-agent-5control-ipv4.

Requires: openshift/assisted-service#6917

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2024 •
edited by openshift-ci bot
Loading

@rwsu: This pull request references AGENT-992 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

The job's name is e2e-agent-5control-ipv4.

Depends on openshift/installer#9154.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@openshift-ci openshift-ci bot requested review from jhixson74 and rna-afk November 7, 2024 21:52
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2024 •
edited by openshift-ci bot
Loading

@rwsu: This pull request references AGENT-992 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

The job's name is e2e-agent-5control-ipv4.

Requires: openshift/assisted-service#6917

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rwsu
Copy link
Contributor Author

rwsu commented Nov 8, 2024

/cc @andfasano @bfournie @pawanpinjarkar

@rwsu rwsu changed the title AGENT-992: Presubmit CI job to test control plane with 5 replicas AGENT-992: installer presubmit job to test control plane with 5 replicas Nov 8, 2024
andfasano
andfasano reviewed Nov 8, 2024
View reviewed changes
ci-operator/config/openshift/installer/openshift-installer-master.yaml
workflow: agent-e2e-ha-dualstack
timeout: 6h0m0s
- as: e2e-agent-5control-ipv4
cluster: build05
Copy link
Contributor

@andfasano andfasano Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be optional this job?

Copy link
Contributor Author

@rwsu rwsu Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be optional. Thanks for catching it.

@andfasano
Copy link
Contributor

andfasano commented Nov 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@rwsu
AGENT-992: Presubmit job to test control plane with 4 and 5 replicas
fa69a68 
The jobs are named e2e-agent-4control-ipv4 and
e2e-agent-5control-ipv4.

Requires: openshift/assisted-service#6917
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@rwsu
Copy link
Contributor Author

rwsu commented Nov 12, 2024

I updated the PR to add a job for 4 replicas.

@rwsu rwsu changed the title AGENT-992: installer presubmit job to test control plane with 5 replicas AGENT-992: installer presubmit job to test control plane with 4 and 5 replicas Nov 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2024

[REHEARSALNOTIFIER]
@rwsu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-agent-4control-ipv4 openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-master-e2e-agent-5control-ipv4 openshift/installer presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rwsu
Copy link
Contributor Author

rwsu commented Nov 14, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2024

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andfasano
Copy link
Contributor

andfasano commented Nov 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rwsu
Copy link
Contributor Author

rwsu commented Nov 15, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 15, 2024

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5b03f13 into openshift:master Nov 15, 2024
17 checks passed
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Nov 17, 2024
@rwsu @obochan-rh
AGENT-992: Presubmit job to test control plane with 4 and 5 replicas (o…
7626682 
…penshift#58621)

The jobs are named e2e-agent-4control-ipv4 and
e2e-agent-5control-ipv4.

Requires: openshift/assisted-service#6917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@rna-afk rna-afk Awaiting requested review from rna-afk

@bfournie bfournie Awaiting requested review from bfournie

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rwsu @openshift-ci-robot @andfasano