AGENT-990: Allow control planes with 5 and 4 replicas #9154
Conversation
|
@rwsu: This pull request references AGENT-990 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
pkg/asset/agent/installconfig.go
Outdated
There was a problem hiding this comment.
| if *installConfig.ControlPlane.Replicas != 1 && *installConfig.ControlPlane.Replicas != 3 && *installConfig.ControlPlane.Replicas != 4 && *installConfig.ControlPlane.Replicas != 5 { | |
| if *installConfig.ControlPlane.Replicas < 1 || *installConfig.ControlPlane.Replicas > 5 ||*installConfig.ControlPlane.Replicas == 2 { |
Slightly shorter comparison
rwsu
force-pushed
the
5-control
branch
2 times, most recently
from
b3903af to
4a2295a
Compare
pkg/asset/agent/installconfig.go
Outdated
There was a problem hiding this comment.
(and very likely we'll have to remove the 2 case after #9159 will land)
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Remaining retests: 0 against base HEAD 95fda29 and 2 for PR HEAD 4a2295adc8b0320d3a6d50143f37d67b3dbb8d07 in total |
|
/retest-required Remaining retests: 0 against base HEAD a563147 and 1 for PR HEAD 4a2295adc8b0320d3a6d50143f37d67b3dbb8d07 in total |
|
Needed to update integration test to include userManagedNetworking: false after rebase. |
The job's name is e2e-agent-5control-ipv4. Depends on openshift/installer#9154.
|
/lgtm |
|
@rwsu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
5 participants
No description provided.