Automating OCP-55033 in Origin #30512
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
test/extended/node/node_e2e/node.go
Outdated
| //author: asahay@redhat.com | ||
| g.It("check KUBELET_LOG_LEVEL is 2", func() { | ||
| g.By("check Kubelet Log Level\n") | ||
| assertKubeletLogLevel(oc) |
There was a problem hiding this comment.
It is a better practice to have all the assertions and test logic in the test. The helper functions should just do stuff and return information. This makes the tests more readable and allows the helper functions to be more reusable.
| e2e "k8s.io/kubernetes/test/e2e/framework" | ||
| ) | ||
|
|
||
| func assertKubeletLogLevel(oc *exutil.CLI) { |
There was a problem hiding this comment.
Do you expect that this function will be used in another test? Maybe it is not needed. Just put it all in the test. We can refactor later if we discover that is it reusable.
| var kublet string | ||
| var err error | ||
| waitErr := wait.Poll(10*time.Second, 1*time.Minute, func() (bool, error) { | ||
| nodeName, nodeErr := oc.AsAdmin().WithoutNamespace().Run("get").Args("nodes", "-o=jsonpath={.items[*].metadata.name}").Output() |
There was a problem hiding this comment.
Assuming this code gets factored back in to the test, it would be good to see some By()s to clarify what the test is doing.
|
Scheduling required tests: |
|
/test e2e-vsphere-ovn-upi |
|
/test e2e-vsphere-ovn |
| e2e "k8s.io/kubernetes/test/e2e/framework" | ||
| ) | ||
|
|
||
| var _ = g.Describe("[sig-node] Kubelet, CRI-O, CPU manager", func() { |
There was a problem hiding this comment.
The new labeling method is to use [jira:"Node / Kubelet]"] per https://docs.google.com/document/d/1cFZj9QdzW8hbHc3H0Nce-2xrJMtpDJrwAse9H7hLiWk/edit?tab=t.0#heading=h.v059hn4ylc6b
There was a problem hiding this comment.
also "Add the “[OTP]” annotation in the test name to tests that are ported, this is for tracking purposes so we can get a rough idea of how many tests have come over."
|
@asahay19: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: asahay19, cpmeadors, lyman9966 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
This case is about checking the Kubelet log level is 2.
Here is the test case link : https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-55033
It is duplicate of PR: #30460
PR: 30460 got closed because I had to delete repo, so creating new PR again with addressing all the comments.
PTAL @sairameshv @lyman9966 @cpmeadors