Skip to content

Conversation

@asahay19
Copy link
Contributor

@asahay19 asahay19 commented Nov 5, 2025

This case is about checking the Kubelet log level is 2.
Here is the test case link : https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-55033

I have ran that locally and it got passed:

` ./openshift-tests run-test "[sig-node] NODE initContainer policy,volume,readines,quota check KUBELET_LOG_LEVEL is 2 [Suite:openshift/conformance/parallel]"

Running Suite: - /Users/asahay/OCP-55033/origin

Random Seed: 1762945017 - will randomize all specs

Will run 1 of 1 specs

[sig-node] NODE initContainer policy,volume,readines,quota check KUBELET_LOG_LEVEL is 2
github.com/openshift/origin/test/extended/node/node.go:15
STEP: Creating a kubernetes client @ 11/12/25 16:27:01.774
I1112 16:27:01.775613 60942 discovery.go:214] Invalidating discovery information
STEP: check Kubelet Log Level
@ 11/12/25 16:27:01.775
I1112 16:27:13.581561 60942 node_utils.go:22]
Node Names are ip-10-0-11-243.us-east-2.compute.internal ip-10-0-15-30.us-east-2.compute.internal ip-10-0-55-165.us-east-2.compute.internal ip-10-0-56-233.us-east-2.compute.internal ip-10-0-75-169.us-east-2.compute.internal ip-10-0-95-145.us-east-2.compute.internal
I1112 16:27:14.689276 60942 node_utils.go:28]
Node ip-10-0-11-243.us-east-2.compute.internal Status is True

I1112 16:27:24.692931 60942 node_utils.go:37] KUBELET_LOG_LEVEL is 2.

• [22.939 seconds]

Ran 1 of 1 Specs in 22.939 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
{
"name": "[sig-node] NODE initContainer policy,volume,readines,quota check KUBELET_LOG_LEVEL is 2 [Suite:openshift/conformance/parallel]",
"lifecycle": "blocking",
"duration": 22939,
"startTime": "2025-11-12 10:57:01.757463 UTC",
"endTime": "2025-11-12 10:57:24.697116 UTC",
"result": "passed",
"output": " STEP: Creating a kubernetes client @ 11/12/25 16:27:01.774\n STEP: check Kubelet Log Level\n @ 11/12/25 16:27:01.775\nI1112 16:27:13.581561 60942 node_utils.go:22] \nNode Names are ip-10-0-11-243.us-east-2.compute.internal ip-10-0-15-30.us-east-2.compute.internal ip-10-0-55-165.us-east-2.compute.internal ip-10-0-56-233.us-east-2.compute.internal ip-10-0-75-169.us-east-2.compute.internal ip-10-0-95-145.us-east-2.compute.internal\nI1112 16:27:14.689276 60942 node_utils.go:28] \nNode ip-10-0-11-243.us-east-2.compute.internal Status is True\n\nI1112 16:27:24.692931 60942 node_utils.go:37] KUBELET_LOG_LEVEL is 2. \n\n"
}
]`

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial November 5, 2025 13:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asahay19
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 5, 2025
@openshift-trt
Copy link

openshift-trt bot commented Nov 5, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: c55cf6a

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-node] NODE initContainer policy,volume,readines,quota check KUBELET_LOG_LEVEL is 2 [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit

New tests seen in this PR at sha: c55cf6a

  • "[sig-node] NODE initContainer policy,volume,readines,quota check KUBELET_LOG_LEVEL is 2 [Suite:openshift/conformance/parallel]" [Total: 6, Pass: 5, Fail: 1, Flake: 0]

@asahay19 asahay19 changed the title [WIP] Automation of OCP-55033 Automation of OCP-55033 Nov 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2025
@@ -0,0 +1,19 @@
package node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name can follow the convention other tests are using for example: test/extended/node/image_volume.go
I suggest test/extended/node/check_log_level.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this File have been created for all the node QE e2e test cases which will be migrating from openshift-test-private to origin. Because all the cases are not linked to a Feature. So, for any specific feature yes we can create file like that but for the cases in OTP , we need one file like this .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The origin test suite already has the ability to run test cases in parallel, that would run faster than grouping the tests. If checking the log level is one test case, it can run independently. So we may not need a common "node.go"

//e2e "k8s.io/kubernetes/test/e2e/framework"
)

var _ = g.Describe("[sig-node] NODE initContainer policy,volume,readines,quota", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already using [sig-node] , so "NODE" can be removed

@@ -0,0 +1,61 @@
package node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be part of the test instead of a node_utils as this is the real test.

e2e "k8s.io/kubernetes/test/e2e/framework"
)

func assertKubeletLogLevel(oc *exutil.CLI) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the test pass on all the platforms? I think the debug pod image may not be available on all platforms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on aws, gcp, arm64 and amd64 builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if all the tests that run as part of the PR itself passes? For example, microshift.

@@ -0,0 +1,12 @@
reviewers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding reviewers could be a different PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it does in a same PR. I have updated it now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting this change to the OWNERS to be a different PR so that this PR focusses on the test.

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 12, 2025
@openshift-trt
Copy link

openshift-trt bot commented Nov 12, 2025

Job Failure Risk Analysis for sha: bc75f72

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi High
[Monitor:pod-network-avalibility][sig-network] can collect network.openshift.io/disruption-actor=poller,network.openshift.io/disruption-target=pod-to-service poller pod logs
This test has passed 99.66% of 4405 runs on release 4.21 [Overall] in the last week.
---
[Monitor:pod-network-avalibility][sig-network] can collect network.openshift.io/disruption-actor=poller,network.openshift.io/disruption-target=host-to-service poller pod logs
This test has passed 99.66% of 4405 runs on release 4.21 [Overall] in the last week.
---
[Monitor:apiserver-incluster-availability][Jira: "kube-apiserver"] can collect apiserver.openshift.io/disruption-actor=poller poller pod logs
This test has passed 99.98% of 4265 runs on release 4.21 [Overall] in the last week.
---
[Monitor:pod-network-avalibility][sig-network] can collect network.openshift.io/disruption-actor=poller,network.openshift.io/disruption-target=host-to-pod poller pod logs
This test has passed 99.70% of 4405 runs on release 4.21 [Overall] in the last week.
---
Showing 4 of 8 test results

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: bc75f72

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-node] NODE initContainer policy,volume,readines,quota check KUBELET_LOG_LEVEL is 2 [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit

New tests seen in this PR at sha: bc75f72

  • "[sig-node] NODE initContainer policy,volume,readines,quota check KUBELET_LOG_LEVEL is 2 [Suite:openshift/conformance/parallel]" [Total: 6, Pass: 5, Fail: 1, Flake: 0]

//e2e "k8s.io/kubernetes/test/e2e/framework"
)

var _ = g.Describe("[sig-node] NODE initContainer policy,volume,readines,quota", func() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "NODE initContainer policy,volume,readines,quota" is historically-created, not precise, use "Kubelet, CRI-O, CPU manager" can be better and we can update it along with other feature cases coming in.

import (
g "github.com/onsi/ginkgo/v2"
exutil "github.com/openshift/origin/test/extended/util"
//e2e "k8s.io/kubernetes/test/e2e/framework"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comment if it is never used in the code

return false, nil
}
} else {
e2e.Logf("\n NODES ARE NOT READY\n ")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e2e.Logf("\n NODES ARE NOT READY\n ")
e2e.Logf("\n Node %s is not Ready, Skipping\n ", node)

if waitErr != nil {
e2e.Logf("Kubelet Log level is:\n %v\n", kubeservice)
e2e.Logf("Running Proccess of kubelet are:\n %v\n", kublet)
AssertWaitPollNoErr(waitErr, "KUBELET_LOG_LEVEL is not expected")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can delete func AssertWaitPollNoErr() and replace it with:
o.Expect(waitErr).NotTo(o.HaveOccurred(), "KUBELET_LOG_LEVEL is not expected, timed out")

@asahay19
Copy link
Contributor Author

/test verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@asahay19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi bc75f72 link true /test e2e-aws-csi
ci/prow/e2e-aws-ovn-microshift-serial bc75f72 link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-serial-1of2 bc75f72 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-fips bc75f72 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial-2of2 bc75f72 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-ovn-upgrade bc75f72 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn bc75f72 link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn bc75f72 link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-csi bc75f72 link true /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-microshift bc75f72 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-vsphere-ovn-upi bc75f72 link true /test e2e-vsphere-ovn-upi
ci/prow/verify 2989d03 link true /test verify
ci/prow/e2e-metal-ipi-ovn-ipv6 2989d03 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@asahay19 asahay19 closed this by deleting the head repository Nov 20, 2025
@asahay19
Copy link
Contributor Author

New PR link : http://github.com/openshift/origin/pull/30512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants