Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1898: Revert "NO-JIRA: address malformed CMO configmap post-test" #29330

Merged
merged 1 commit into from
Nov 28, 2024
Merged

TRT-1898: Revert "NO-JIRA: address malformed CMO configmap post-test" #29330

merged 1 commit into from
Nov 28, 2024
+5 −13

Conversation

xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Nov 27, 2024 •
edited
Loading

Reverts #29309; tracked by https://issues.redhat.com/browse/OCPBUGS-45153

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR has causd the nightly failures for many techpreview jobs. Here is one example: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview/1861677512929579008

Test is stuck with this error:

I1127 09:11:20.327512 62130 client.go:421] Project "e2e-test-monitoring-collection-profiles-mqvzf" has been fully provisioned.
STEP: restoring the original configuration for the operator @ 11/27/24 09:11:21.232
[INTERRUPTED] in [AfterAll] - github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99 @ 11/27/24 09:26:06.355
------------------------------
Interrupted by User
First interrupt received; Ginkgo will run any cleanup and reporting nodes but will skip all remaining specs. Interrupt again to skip cleanup.
Here's a current progress report:
[sig-instrumentation][OCPFeatureGate:MetricsCollectionProfiles] The collection profiles feature-set initially, in a homogeneous default environment, should expose default metrics [Suite:openshift/conformance/parallel] (Spec Runtime: 14m49.846s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:140
In [AfterAll] (Node Runtime: 14m45.187s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99
At [By Step] restoring the original configuration for the operator (Step Runtime: 14m45.123s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:104

      Spec Goroutine
      goroutine 236 [select]
        github.com/onsi/gomega/internal.(*AsyncAssertion).match(0xc000fa2070, {0x7e574e8, 0xc23fb80}, 0x1, {0x0, 0x0, 0x0})
          github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:538
        github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0xc000fa2070, {0x7e574e8, 0xc23fb80}, {0x0, 0x0, 0x0})
          github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:145
      > github.com/openshift/origin/test/extended/prometheus.init.func1.2()
          github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:118
        github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0xc006c77b00?, 0xc006c5fe00?})
          github.com/onsi/ginkgo/v2@v2.20.2/internal/node.go:472
        github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
          github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:901
        github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 1
          github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:888
------------------------------

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

CC: @rexagod

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2024
@openshift-ci-robot
Copy link

@xueqzhan: This pull request explicitly references no jira issue.

In response to this:

Reverts #29309

This is likely the cause for the nightly failure for many techpreview jobs. Here is one example: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview/1861677512929579008

Test is stuck with this error:

I1127 09:11:20.327512 62130 client.go:421] Project "e2e-test-monitoring-collection-profiles-mqvzf" has been fully provisioned.
STEP: restoring the original configuration for the operator @ 11/27/24 09:11:21.232
[INTERRUPTED] in [AfterAll] - github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99 @ 11/27/24 09:26:06.355

Interrupted by User
First interrupt received; Ginkgo will run any cleanup and reporting nodes but will skip all remaining specs. Interrupt again to skip cleanup.
Here's a current progress report:
[sig-instrumentation][OCPFeatureGate:MetricsCollectionProfiles] The collection profiles feature-set initially, in a homogeneous default environment, should expose default metrics [Suite:openshift/conformance/parallel] (Spec Runtime: 14m49.846s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:140
In [AfterAll] (Node Runtime: 14m45.187s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99
At [By Step] restoring the original configuration for the operator (Step Runtime: 14m45.123s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:104

     Spec Goroutine
     goroutine 236 [select]
       github.com/onsi/gomega/internal.(*AsyncAssertion).match(0xc000fa2070, {0x7e574e8, 0xc23fb80}, 0x1, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:538
       github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0xc000fa2070, {0x7e574e8, 0xc23fb80}, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:145
     > github.com/openshift/origin/test/extended/prometheus.init.func1.2()
         github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:118
       github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0xc006c77b00?, 0xc006c5fe00?})
         github.com/onsi/ginkgo/v2@v2.20.2/internal/node.go:472
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
         github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:901
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 1
         github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:888

I will run some test and update the comment once confirmed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b549ebd0-ad0f-11ef-8062-decdcf8b80a5-0

@openshift-ci openshift-ci bot requested review from jan--f and machine424 November 27, 2024 22:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@sosiouxme sosiouxme changed the title Revert "NO-JIRA: address malformed CMO configmap post-test" TRT-1898: Revert "NO-JIRA: address malformed CMO configmap post-test" Nov 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2024 •
edited by openshift-ci bot
Loading

@xueqzhan: This pull request references TRT-1898 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.19.0" version, but no target version was set.

In response to this:

Reverts #29309

This is likely the cause for the nightly failure for many techpreview jobs. Here is one example: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview/1861677512929579008

Test is stuck with this error:

I1127 09:11:20.327512 62130 client.go:421] Project "e2e-test-monitoring-collection-profiles-mqvzf" has been fully provisioned.
STEP: restoring the original configuration for the operator @ 11/27/24 09:11:21.232
[INTERRUPTED] in [AfterAll] - github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99 @ 11/27/24 09:26:06.355

Interrupted by User
First interrupt received; Ginkgo will run any cleanup and reporting nodes but will skip all remaining specs. Interrupt again to skip cleanup.
Here's a current progress report:
[sig-instrumentation][OCPFeatureGate:MetricsCollectionProfiles] The collection profiles feature-set initially, in a homogeneous default environment, should expose default metrics [Suite:openshift/conformance/parallel] (Spec Runtime: 14m49.846s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:140
In [AfterAll] (Node Runtime: 14m45.187s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99
At [By Step] restoring the original configuration for the operator (Step Runtime: 14m45.123s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:104

     Spec Goroutine
     goroutine 236 [select]
       github.com/onsi/gomega/internal.(*AsyncAssertion).match(0xc000fa2070, {0x7e574e8, 0xc23fb80}, 0x1, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:538
       github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0xc000fa2070, {0x7e574e8, 0xc23fb80}, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:145
     > github.com/openshift/origin/test/extended/prometheus.init.func1.2()
         github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:118
       github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0xc006c77b00?, 0xc006c5fe00?})
         github.com/onsi/ginkgo/v2@v2.20.2/internal/node.go:472
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
         github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:901
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 1
         github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:888

I will run some test and update the comment once confirmed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sosiouxme
Copy link
Member

payload job passed
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 90bc491 and 2 for PR HEAD e40dada in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2024 •
edited by openshift-ci bot
Loading

@xueqzhan: This pull request references TRT-1898 which is a valid jira issue.

In response to this:

Reverts #29309; tracked by https://issues.redhat.com/browse/OCPBUGS-45153

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR has causd the nightly failures for many techpreview jobs. Here is one example: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview/1861677512929579008

Test is stuck with this error:

I1127 09:11:20.327512 62130 client.go:421] Project "e2e-test-monitoring-collection-profiles-mqvzf" has been fully provisioned.
STEP: restoring the original configuration for the operator @ 11/27/24 09:11:21.232
[INTERRUPTED] in [AfterAll] - github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99 @ 11/27/24 09:26:06.355

Interrupted by User
First interrupt received; Ginkgo will run any cleanup and reporting nodes but will skip all remaining specs. Interrupt again to skip cleanup.
Here's a current progress report:
[sig-instrumentation][OCPFeatureGate:MetricsCollectionProfiles] The collection profiles feature-set initially, in a homogeneous default environment, should expose default metrics [Suite:openshift/conformance/parallel] (Spec Runtime: 14m49.846s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:140
In [AfterAll] (Node Runtime: 14m45.187s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:99
At [By Step] restoring the original configuration for the operator (Step Runtime: 14m45.123s)
github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:104

     Spec Goroutine
     goroutine 236 [select]
       github.com/onsi/gomega/internal.(*AsyncAssertion).match(0xc000fa2070, {0x7e574e8, 0xc23fb80}, 0x1, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:538
       github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0xc000fa2070, {0x7e574e8, 0xc23fb80}, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.34.2/internal/async_assertion.go:145
     > github.com/openshift/origin/test/extended/prometheus.init.func1.2()
         github.com/openshift/origin/test/extended/prometheus/collection_profiles.go:118
       github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0xc006c77b00?, 0xc006c5fe00?})
         github.com/onsi/ginkgo/v2@v2.20.2/internal/node.go:472
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
         github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:901
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 1
         github.com/onsi/ginkgo/v2@v2.20.2/internal/suite.go:888

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

CC: @rexagod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@xueqzhan: Overrode contexts on behalf of xueqzhan: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xueqzhan
Copy link
Contributor Author

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@xueqzhan: Overrode contexts on behalf of xueqzhan: ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

In response to this:

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3020953 into openshift:master Nov 28, 2024
19 of 28 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd e40dada link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-kube-apiserver-rollout e40dada link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-upgrade e40dada link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade e40dada link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-upgrade e40dada link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn e40dada link false /test e2e-metal-ipi-ovn
ci/prow/e2e-openstack-ovn e40dada link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-csi e40dada link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411280538.p0.g3020953.assembly.stream.el9.
All builds following this will include this PR.

@rexagod
Copy link
Member

rexagod commented Nov 28, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@rexagod: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ead857a0-adb4-11ef-847d-a7a19d6ffba0-0

This was referenced Nov 29, 2024
Open
Open
rexagod added a commit to rexagod/origin that referenced this pull request Dec 2, 2024
@rexagod
Revert "Merge pull request openshift#29330 from xueqzhan/revert-29309…
346c86e 
…-malformed-config"

This reverts commit 3020953, reversing
changes made to 90bc491.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@machine424 machine424 Awaiting requested review from machine424

Assignees

@sosiouxme sosiouxme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xueqzhan @openshift-ci-robot @sosiouxme @openshift-bot @rexagod