Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: address malformed CMO configmap post-test #29309

Merged
merged 3 commits into from
Nov 26, 2024
Merged

NO-JIRA: address malformed CMO configmap post-test #29309

merged 3 commits into from
Nov 26, 2024

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Nov 20, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@openshift-ci-robot
Copy link

@rexagod: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rexagod
Copy link
Member Author

rexagod commented Nov 20, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@rexagod: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a6d8cc40-a721-11ef-9610-9f6007979bc0-0

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
simonpasquier
simonpasquier reviewed Nov 20, 2024
View reviewed changes
test/extended/prometheus/collection_profiles.go Outdated
@@ -84,14 +84,12 @@ var _ = g.Describe("[sig-instrumentation][OCPFeatureGate:MetricsCollectionProfil
if err != nil {
if errors.IsNotFound(err) {
g.By("initially, creating a configuration for the operator as it did not exist")
operatorConfiguration = nil
err = r.makeCollectionProfileConfigurationFor(tctx, collectionProfileDefault)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the 2 other suggestions, I find the code flow to be easier to read.

Suggested change
err = r.makeCollectionProfileConfigurationFor(tctx, collectionProfileDefault)
return r.makeCollectionProfileConfigurationFor(tctx, collectionProfileDefault)

test/extended/prometheus/collection_profiles.go Show resolved Hide resolved
test/extended/prometheus/collection_profiles.go Outdated
}

return nil
return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return err
return nil

@rexagod
Copy link
Member Author

rexagod commented Nov 20, 2024

Thank you for the review, Simon. I'm keeping an eye out for the payload-job above and will post the results as soon as that's done. 🤞🏼 for a green CI.

@rexagod
Copy link
Member Author

rexagod commented Nov 21, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-techpreview-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@rexagod: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@rexagod
fixup! fixup! address malformed configmap post-test
c4c4e96 
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Member Author

rexagod commented Nov 21, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@rexagod: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e16d4690-a7e1-11ef-8402-8fcc4c703a9c-0

@rexagod
Copy link
Member Author

rexagod commented Nov 21, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@rexagod: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f6975dd0-a7e1-11ef-82ff-8e570b0d9c7c-0

@rexagod
Copy link
Member Author

rexagod commented Nov 21, 2024

/retest

@rexagod rexagod closed this Nov 21, 2024
@rexagod rexagod reopened this Nov 21, 2024
@rexagod
Copy link
Member Author

rexagod commented Nov 21, 2024

/retest

@rexagod
Copy link
Member Author

rexagod commented Nov 21, 2024 •
edited
Loading

Test results on metal-dualstack-techpreview and metal-ipv6-techpreview seem okay for the ones that concern us.

Also, no flakes w.r.t. any of our tests on either of these runs.

@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8dfcab3 and 2 for PR HEAD c4c4e96 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024 •
edited
Loading

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn c4c4e96 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn c4c4e96 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-gcp-ovn-rt-upgrade c4c4e96 link false /test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8dfcab3 and 2 for PR HEAD c4c4e96 in total

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Nov 26, 2024

Job Failure Risk Analysis for sha: c4c4e96

Job Name Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn IncompleteTests
Tests for this run (12) are below the historical average (2793): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-merge-bot openshift-merge-bot bot merged commit e25fe13 into openshift:master Nov 26, 2024
16 of 28 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411260743.p0.ge25fe13.assembly.stream.el9.
All builds following this will include this PR.

@xueqzhan xueqzhan mentioned this pull request Nov 27, 2024
Merged
@xueqzhan
Copy link
Contributor

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cd8031a0-ad0f-11ef-9517-d4a3ccf5d7fe-0

@rexagod rexagod mentioned this pull request Nov 29, 2024
Open
@rexagod
Copy link
Member Author

rexagod commented Nov 29, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-crun-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

@rexagod: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-crun-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aef6b800-ae61-11ef-8ec5-24fd4cd39441-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rexagod @openshift-ci-robot @simonpasquier @openshift-bot @xueqzhan