Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fake image injections for k8s 1.28 #28250

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Sep 11, 2023

Reverts #28200 #28248
/assign @bertinatto

@soltysh
Copy link
Contributor Author

soltysh commented Sep 11, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 11, 2023
@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2023
@bertinatto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgoodwin
Copy link
Contributor

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-builds, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-sdn, ci/prow/e2e-openstack-ovn

In response to this:

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ed9e4ca into openshift:master Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@soltysh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh soltysh deleted the revert_images branch September 11, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants