Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1425: Add images coming in k8s 1.28 #28200

Merged
merged 1 commit into from
Sep 8, 2023
Merged

STOR-1425: Add images coming in k8s 1.28 #28200

merged 1 commit into from
Sep 8, 2023

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Aug 17, 2023

Some of the metal jobs rely on information which images need to be mirrored, this information is coming in #28097 but to properly assess correctness we need those information sooner.

This PR injects that image information directly into ./openshift-tests images command.

/hold
Until master branch opens for OCP 4.15.

/assign @bertinatto

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 17, 2023 •
edited by openshift-ci bot
Loading

@soltysh: This pull request references STOR-1425 which is a valid jira issue.

In response to this:

Some of the metal jobs rely on information which images need to be mirrored, this information is coming in #28097 but to properly assess correctness we need those information sooner.

This PR injects that image information directly into ./openshift-tests images command.

/hold
Until master branch opens for OCP 4.15.

/assign @bertinatto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@openshift-ci openshift-ci bot requested review from bertinatto and bparees August 17, 2023 12:00
@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2023
bertinatto
bertinatto reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@bertinatto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member

/retest-required

@bertinatto
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 025ad59 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 025ad59 link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 025ad59 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node 025ad59 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial 025ad59 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn 025ad59 link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor Author

soltysh commented Sep 8, 2023

/hold cancel
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 8, 2023
@bertinatto
Copy link
Member

/refresh-status

@openshift-merge-robot openshift-merge-robot merged commit 9fb1066 into openshift:master Sep 8, 2023
@soltysh soltysh deleted the inject_images branch September 8, 2023 17:13
@soltysh soltysh mentioned this pull request Sep 11, 2023
Merged
@bertinatto bertinatto mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@bparees bparees Awaiting requested review from bparees

Assignees

@bertinatto bertinatto

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soltysh @openshift-ci-robot @bertinatto @openshift-merge-robot