Pod shall not transition from terminated phase: "Failed" -> "Succeeded"

[0xmichalis]

/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/deployments/deployments.go:1299
2017-12-05 09:50:41.393147976 +0000 UTC: detected deployer pod transition from terminated phase: "Failed" -> "Succeeded"
Expected
    <bool>: true
to be false
/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/deployments/util.go:727

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17589/test_pull_request_origin_extended_conformance_install/3497/

/sig master
/kind test-flake
/assign mfojtik tnozicka

xref https://bugzilla.redhat.com/show_bug.cgi?id=1534492

[tnozicka]

@sjenning it seems to already have #17514

I don't think your condition prevents failed->succeded

origin/vendor/k8s.io/kubernetes/pkg/kubelet/status/status_manager.go

Line 286 in 21271eb

if oldStatus.State.Terminated != nil && newStatus.State.Terminated == nil {

There few other flakes likely caused by kubelet not respecting pod state transition diagram:

• deploymentconfigs when run iteratively [Conformance] should only deploy the last deployment  #17581
• flake: jenkins-plugin test imagestream SCM DSL #17487

/assign @sjenning
/unassign @tnozicka @mfojtik
/priority P0

[tnozicka]

(previous issue #17011)