Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 54530: api: validate container phase transitions #18791

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Mar 1, 2018

@sjenning sjenning added the kind/bug Categorizes issue or PR as related to a bug. label Mar 1, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 1, 2018
@sjenning
Copy link
Contributor Author

sjenning commented Mar 1, 2018

/test cmd

@derekwaynecarr derekwaynecarr added this to the 3.9.0 milestone Mar 1, 2018
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2018
@sjenning
Copy link
Contributor Author

sjenning commented Mar 1, 2018

#18794 again
/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjenning
Copy link
Contributor Author

sjenning commented Mar 2, 2018

/retest

1 similar comment
@sjenning
Copy link
Contributor Author

sjenning commented Mar 2, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot added a commit that referenced this pull request Mar 4, 2018
Automatic merge from submit-queue.

[3.9] UPSTREAM: 54530: api: validate container phase transitions

master PR #18791

kubernetes/kubernetes#54530

fixes #17595

xref https://bugzilla.redhat.com/show_bug.cgi?id=1534492

@tnozicka @smarterclayton @derekwaynecarr
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Mar 5, 2018
Automatic merge from submit-queue.

[3.9] UPSTREAM: 54530: api: validate container phase transitions

master PR openshift/origin#18791

kubernetes#54530

fixes kubernetes#17595

xref https://bugzilla.redhat.com/show_bug.cgi?id=1534492

@tnozicka @smarterclayton @derekwaynecarr

Origin-commit: 30679c747f8b96fabaeccd07b1e8742547bf896c
@sjenning
Copy link
Contributor Author

sjenning commented Mar 5, 2018

/retest

@derekwaynecarr
Copy link
Member

/test extended_conformance_install

1 similar comment
@sjenning
Copy link
Contributor Author

sjenning commented Mar 6, 2018

/test extended_conformance_install

@derekwaynecarr
Copy link
Member

on another pr, i see the invalid pod transition happening breaking the pod invariants...

/test_extended_conformance_install

@derekwaynecarr
Copy link
Member

/test extended_conformance_install

@derekwaynecarr
Copy link
Member

given incidence of flake around this invariant, and that the same pr has already merged in 3.9, I will probably big button merge if this doesn’t go green.

@derekwaynecarr
Copy link
Member

omg, it passed!

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@sjenning: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install ac0d38e link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@derekwaynecarr
Copy link
Member

merging manually

@derekwaynecarr derekwaynecarr merged commit 8f44e66 into openshift:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. queue/fix size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod shall not transition from terminated phase: "Failed" -> "Succeeded"
7 participants