-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 54530: api: validate container phase transitions #18791
Conversation
/test cmd |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#18794 again |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Automatic merge from submit-queue. [3.9] UPSTREAM: 54530: api: validate container phase transitions master PR #18791 kubernetes/kubernetes#54530 fixes #17595 xref https://bugzilla.redhat.com/show_bug.cgi?id=1534492 @tnozicka @smarterclayton @derekwaynecarr
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Automatic merge from submit-queue. [3.9] UPSTREAM: 54530: api: validate container phase transitions master PR openshift/origin#18791 kubernetes#54530 fixes kubernetes#17595 xref https://bugzilla.redhat.com/show_bug.cgi?id=1534492 @tnozicka @smarterclayton @derekwaynecarr Origin-commit: 30679c747f8b96fabaeccd07b1e8742547bf896c
/retest |
/test extended_conformance_install |
1 similar comment
/test extended_conformance_install |
on another pr, i see the invalid pod transition happening breaking the pod invariants... /test_extended_conformance_install |
/test extended_conformance_install |
given incidence of flake around this invariant, and that the same pr has already merged in 3.9, I will probably big button merge if this doesn’t go green. |
omg, it passed! |
/test all [submit-queue is verifying that this PR is safe to merge] |
@sjenning: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
merging manually |
kubernetes/kubernetes#54530
fixes #17595
xref https://bugzilla.redhat.com/show_bug.cgi?id=1534492
@tnozicka @smarterclayton @derekwaynecarr