Skip to content

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Sep 16, 2024

Version(s): 4.17+

Issue: OCPBUGS-39132

Link to docs preview: https://81888--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_openstack/deploying-openstack-with-rootVolume-etcd-on-local-disk.html

QE review:

  • QE has approved this change.

Additional information: What a silly typo in the branch name. :)

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2024
@maxwelldb
Copy link
Contributor Author

/retest

@openshift openshift deleted a comment from openshift-ci bot Sep 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 16, 2024

@rlobillo
Copy link

Hello @maxwelldb

The steps 5 and 6 can be eliminated. To apply this procedure it is needed to create flavor with --ephemeral 10 as it is already done in step 1. Therefore, 5 and 6 are not correct.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2024
@maxwelldb
Copy link
Contributor Author

@rlobillo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@maxwelldb maxwelldb added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.17 labels Sep 18, 2024
@maxwelldb maxwelldb added this to the Continuous Release milestone Sep 18, 2024
@maxwelldb maxwelldb force-pushed the shiftstack-etcd-ephemperal-ocpbugs39132 branch from 5a52bb6 to 527669c Compare September 18, 2024 14:28
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2024

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We are all ephemperal creatures, I suppose! 👍

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 18, 2024
@GroceryBoyJr
Copy link
Contributor

Wow. The openshift-ci bot is slow today.

@maxwelldb maxwelldb requested a review from rlobillo September 19, 2024 21:33
@maxwelldb
Copy link
Contributor Author

lgtmed already--removing request.

@maxwelldb maxwelldb merged commit 023f0c2 into openshift:main Sep 19, 2024
@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.17

@maxwelldb maxwelldb removed the request for review from rlobillo September 19, 2024 21:34
@maxwelldb maxwelldb deleted the shiftstack-etcd-ephemperal-ocpbugs39132 branch September 19, 2024 21:34
@openshift-cherrypick-robot

@maxwelldb: new pull request created: #82208

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants