-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS#9716] GA OpenStack with rootVolume and etcd on local disk #81714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSDOCS#9716] GA OpenStack with rootVolume and etcd on local disk #81714
Conversation
|
🤖 Fri Sep 20 15:44:15 - Prow CI generated the docs preview: |
|
/retest |
|
Hello @maxwelldb. Please see below some comments:
|
|
I'll cherry-pick the current state of the related bugfix (77417e4) while I roll your suggestions into this. The preview should update shortly after that, assuming Prow stays functional. 🤞 The warning on L11 is removed in this PR already. |
de13664 to
26c483c
Compare
|
@rlobillo Updated. Preview link in PR description should have the latest after CI passes. |
|
/lgtm |
3d05040 to
dc98ab7
Compare
|
New changes are detected. LGTM label has been removed. |
|
/cherry-pick enterprise-4.17 |
|
@maxwelldb: once the present PR merges, I will cherry-pick it on top of enterprise-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@maxwelldb: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label peer-review-in-progress |
cbippley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/label peer-review-done |
|
@maxwelldb: new pull request created: #82227 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.17
Issue: OSDOCS-9716
Link to docs preview: https://81714--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_openstack/deploying-openstack-with-rootVolume-etcd-on-local-disk.html
QE review:
Additional information: #81888 is merged. I think I'll just end up incorporating #81889 into this.