Skip to content

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Sep 12, 2024

Version(s): 4.17

Issue: OSDOCS-9716

Link to docs preview: https://81714--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_openstack/deploying-openstack-with-rootVolume-etcd-on-local-disk.html

QE review:

  • QE has approved this change.

Additional information: #81888 is merged. I think I'll just end up incorporating #81889 into this.

@maxwelldb maxwelldb added this to the Planned for 4.17 GA milestone Sep 12, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 12, 2024

@maxwelldb
Copy link
Contributor Author

Will incorporate #81888 and #81889

@maxwelldb maxwelldb self-assigned this Sep 19, 2024
@maxwelldb maxwelldb requested a review from rlobillo September 19, 2024 22:00
@maxwelldb
Copy link
Contributor Author

/retest

@maxwelldb maxwelldb closed this Sep 19, 2024
@maxwelldb maxwelldb reopened this Sep 19, 2024
@rlobillo
Copy link

Hello @maxwelldb.

Please see below some comments:

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Sep 20, 2024

I'll cherry-pick the current state of the related bugfix (77417e4) while I roll your suggestions into this. The preview should update shortly after that, assuming Prow stays functional. 🤞

The warning on L11 is removed in this PR already.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@maxwelldb maxwelldb force-pushed the shiftstack-etcd-volumes-osdocs9716 branch from de13664 to 26c483c Compare September 20, 2024 14:27
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2024
@maxwelldb
Copy link
Contributor Author

@rlobillo Updated. Preview link in PR description should have the latest after CI passes.

@rlobillo
Copy link

/lgtm

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@maxwelldb maxwelldb force-pushed the shiftstack-etcd-volumes-osdocs9716 branch from 3d05040 to dc98ab7 Compare September 20, 2024 15:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

New changes are detected. LGTM label has been removed.

@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.17

@openshift-cherrypick-robot

@maxwelldb: once the present PR merges, I will cherry-pick it on top of enterprise-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cbippley
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 20, 2024
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbippley
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 20, 2024
@maxwelldb maxwelldb merged commit cec5661 into openshift:main Sep 20, 2024
@openshift-cherrypick-robot

@maxwelldb: new pull request created: #82227

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants