Skip to content

Editing the link based on post-merged feedback to OSDOCS-7764 #66579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

Editing the link based on post-merged feedback to OSDOCS-7764 #66579

merged 1 commit into from
Oct 24, 2023

Conversation

@jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Oct 19, 2023 •
edited
Loading

OSDOCS-7764: Feedback regarding the link was received after merge was complete. The edits are in this PR.

Version(s):
4.13+

Issue:
#66189

Link to docs preview:
https://66579--docspreview.netlify.app/openshift-rosa/latest/rosa_install_access_delete_clusters/rosa-shared-vpc-config

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 19, 2023

🤖 Build preview is available at:
https://66579--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/29077

@laubai
Copy link
Contributor

laubai commented Oct 24, 2023

LGTM!

@EricPonvelle EricPonvelle added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 branch/enterprise-4.14 labels Oct 24, 2023
@EricPonvelle EricPonvelle merged commit e1f5eb4 into openshift:main Oct 24, 2023
@EricPonvelle
Copy link
Contributor

EricPonvelle commented Oct 24, 2023

/cherrypick enterprise-4.13

@EricPonvelle
Copy link
Contributor

EricPonvelle commented Oct 24, 2023

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 24, 2023

@EricPonvelle: new pull request created: #66837

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 24, 2023

@EricPonvelle: new pull request created: #66838

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2023
Merged
@jneczypor jneczypor deleted the OSDOCS-7764 branch October 24, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

branch/enterprise-4.13 branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jneczypor @ocpdocs-previewbot @laubai @EricPonvelle @openshift-cherrypick-robot