Skip to content

Conversation

@jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Oct 12, 2023

OSDOCS-7764: Workflow correction on ROSA Shared VPC doc page

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7764

Link to docs preview:
https://66189--docspreview.netlify.app/openshift-rosa/latest/rosa_install_access_delete_clusters/rosa-shared-vpc-config

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2023

@jneczypor: This pull request references OSDOCS-7764 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7764: Workflow correction on ROSA Shared VPC doc page

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7764

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2023

@jneczypor: This pull request references OSDOCS-7764 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7764: Workflow correction on ROSA Shared VPC doc page

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7764

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2023
@ocpdocs-previewbot
Copy link

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2023

@jneczypor: This pull request references OSDOCS-7764 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7764: Workflow correction on ROSA Shared VPC doc page

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7764

Link to docs preview:
https://66189--docspreview.netlify.app/openshift-rosa/latest/rosa_install_access_delete_clusters/rosa-shared-vpc-config

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jneczypor
Copy link
Contributor Author

Hi @wgordon17 and @yuwang-RH - Can I please get a PM and QE review of this respectively? Thanks so much!

@jneczypor
Copy link
Contributor Author

Hi @wgordon17 - Can I please get a PM review of this PR? I would love to close it this sprint (ends this Friday). Thanks!

Copy link
Contributor

@wgordon17 wgordon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneczypor
Copy link
Contributor Author

Hi @yunjiang29 or @yuwang-RH - Can I please get QE approval for this PR? Thanks so much!

@yunjiang29
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@jneczypor
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 18, 2023
@EricPonvelle EricPonvelle added branch/enterprise-4.13 branch/enterprise-4.14 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 18, 2023
Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@EricPonvelle EricPonvelle merged commit 251cd11 into openshift:main Oct 18, 2023
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.13

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #66509

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #66510

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jneczypor jneczypor deleted the OSDOCS-7764 branch October 18, 2023 23:12
.Procedure

. In the link:https://us-east-1.console.aws.amazon.com/ram/[Resource Access Manager of the AWS console], create a resource share that shares the previously created public and private subnets with the *Cluster Creator's* AWS account ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we can provide a region-agnostic link to this, but it would be good if we could - it seems to connect to your local region if you trim out the us-east-1. from the beginning, so it may be worth specifying that you need to change to the region you want to edit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants