-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-7764: Workflow correction to ROSA Shared VPC page #66189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jneczypor: This pull request references OSDOCS-7764 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@jneczypor: This pull request references OSDOCS-7764 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🤖 Build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27758 |
|
@jneczypor: This pull request references OSDOCS-7764 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @wgordon17 and @yuwang-RH - Can I please get a PM and QE review of this respectively? Thanks so much! |
|
Hi @wgordon17 - Can I please get a PM review of this PR? I would love to close it this sprint (ends this Friday). Thanks! |
wgordon17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @yunjiang29 or @yuwang-RH - Can I please get QE approval for this PR? Thanks so much! |
|
/lgtm |
|
/label peer-review-needed |
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
@EricPonvelle: new pull request created: #66509 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EricPonvelle: new pull request created: #66510 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| .Procedure | ||
|
|
||
| . In the link:https://us-east-1.console.aws.amazon.com/ram/[Resource Access Manager of the AWS console], create a resource share that shares the previously created public and private subnets with the *Cluster Creator's* AWS account ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we can provide a region-agnostic link to this, but it would be good if we could - it seems to connect to your local region if you trim out the us-east-1. from the beginning, so it may be worth specifying that you need to change to the region you want to edit?
OSDOCS-7764: Workflow correction on ROSA Shared VPC doc page
Version(s):
4.13+
Issue:
https://issues.redhat.com/browse/OSDOCS-7764
Link to docs preview:
https://66189--docspreview.netlify.app/openshift-rosa/latest/rosa_install_access_delete_clusters/rosa-shared-vpc-config
QE review:
Additional information: