Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish topic #34053

Merged
merged 1 commit into from
Jul 21, 2021
Merged

RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish topic #34053

merged 1 commit into from
Jul 21, 2021

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jun 28, 2021 •
edited
Loading

For OpenShift 5.1, revert RHDEVDOCS-3007 to republish topic cluster-logging-collector-log-forward-logs-from-application-pods.adoc

This PR reverts commit 87a1845 from #32541 (https://issues.redhat.com/browse/RHDEVDOCS-3007)

I had previously published this content too early with #32334, and then unpublished it by commenting-out the file include in #32541.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2021
@netlify
Copy link

netlify bot commented Jun 28, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: baa1f4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60da160b2573780008ebeed8

😎 Browse the preview: https://deploy-preview-34053--osdocs.netlify.app/openshift-enterprise/latest/logging/cluster-logging-external

@rolfedh
Copy link
Contributor Author

rolfedh commented Jun 28, 2021

/rebuild

@rolfedh
Copy link
Contributor Author

rolfedh commented Jun 28, 2021

/build

@rolfedh
Revert "RHDEVDOCS-3007 temporarily unpublish cluster-logging-collecto…
baa1f4e 
…r-log-forward-logs-from-application-pods.adoc"

This reverts commit 87a1845.
@kabirbhartiRH
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
jc-berger
jc-berger approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, Rolfe, LGTM from doc's point of view!

alanconway
alanconway approved these changes Jun 29, 2021
View reviewed changes
Copy link

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rolfedh rolfedh changed the title Revert "RHDEVDOCS-3007 temporarily unpublish cluster-logging-collecto… RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish cluster-logging-collector-log-forward-logs-from-application-pods.adoc Jul 1, 2021
@rolfedh rolfedh changed the title RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish cluster-logging-collector-log-forward-logs-from-application-pods.adoc RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish topic Jul 1, 2021
@rolfedh rolfedh changed the title RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish topic [WIP]RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish topic Jul 1, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2021
@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Jul 21, 2021
@rolfedh rolfedh changed the title [WIP]RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish topic RHDEVDOCS-3008 At OL 5.1 GA, revert RHDEVDOCS-3007 to republish topic Jul 21, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2021
@Preeticp Preeticp merged commit 8a9cbf8 into openshift:master Jul 21, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #34763

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #34764

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanconway alanconway alanconway approved these changes

@jc-berger jc-berger jc-berger approved these changes

Assignees

@alanconway alanconway

@kabirbhartiRH kabirbhartiRH

Labels
dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rolfedh @kabirbhartiRH @Preeticp @openshift-cherrypick-robot @alanconway @jc-berger