Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-2676 Document "Expose ability to forward logs only from spe… #32334

Merged
merged 1 commit into from
May 11, 2021
Merged

RHDEVDOCS-2676 Document "Expose ability to forward logs only from spe… #32334

merged 1 commit into from
May 11, 2021

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented May 7, 2021 •
edited
Loading

…cific pods via a label selector inside the Log Forwarding API."

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2021
@netlify
Copy link

netlify bot commented May 7, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 73bf0c1

https://deploy-preview-32334--osdocs.netlify.app

@rolfedh
Copy link
Contributor Author

rolfedh commented May 10, 2021

@alanconway Ready for your review and approval.

alanconway
alanconway suggested changes May 10, 2021
View reviewed changes
Copy link

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with one trivial change.

Preeticp
Preeticp reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@Preeticp Preeticp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits/suggestions, otherwise looks great to me.

@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR and removed branch/enterprise-4.7 branch/enterprise-4.8 labels May 11, 2021
alanconway
alanconway reviewed May 11, 2021
View reviewed changes
Copy link

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 11, 2021
@rolfedh
RHDEVDOCS-2676 Document "Expose ability to forward logs only from spe…
73bf0c1 
…cific pods via a label selector inside the Log Forwarding API."
@Preeticp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@Preeticp Preeticp merged commit ab3637f into openshift:master May 11, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 11, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #32432

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #32433

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 11, 2021
Merged
@kabirbhartiRH
Copy link

kabirbhartiRH commented May 11, 2021 •
edited
Loading

/lgtm

Edit: CLF errors out if we define 'default' output in both outputRefs and output field. in-case of default output, only outputRef should be defined and not both. I just validated this.
Please confirm this behavior from SME.
@rolfedh

@rolfedh rolfedh mentioned this pull request Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanconway alanconway alanconway requested changes

@Preeticp Preeticp Preeticp left review comments

Assignees

@alanconway alanconway

@Preeticp Preeticp

Labels
branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rolfedh @Preeticp @openshift-cherrypick-robot @kabirbhartiRH @alanconway