Skip to content

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Jun 9, 2020

Relates to this PR 22785 and this comment:
#22785 (comment)
@bmcelvee Unfortunately, when I add the continuing +, it doesn't continue the callout numbering. (Instead, it lists both callouts as #1.) I couldn't figure out a better workaround, and ultimately reverted back to original formatting. I actually think I mucked with this when the original content was created. Will continue to investigate a fix for this.

@openshift-docs-preview-bot

The preview will be available shortly at:

@bobfuru bobfuru force-pushed the fix-callout-numbering branch from 26ca528 to 855b430 Compare June 9, 2020 19:40
@jboxman
Copy link
Contributor

jboxman commented Jun 9, 2020

@bobfuru, there is this fix:

[start=2]
. Create the CR by running the following command:

Didn't realize it was possible, but an SME had it in a contributed PR.

@jboxman
Copy link
Contributor

jboxman commented Jun 9, 2020

@bobfuru, would love to learn of a clean solution, though.

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 9, 2020

[start=2]

@jboxman I've used this before but couldn't get it to work in this case, which has an admonition note within two callout descriptions. It's also inside of a numbered step, though not sure that should matter.

I ended up just making the note part of <1>. By coincidence, I think it improved readability.
¯_(ツ)_/¯

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 9, 2020
@bobfuru bobfuru merged commit 8bf8e88 into openshift:master Jun 9, 2020
@bobfuru bobfuru deleted the fix-callout-numbering branch June 9, 2020 20:10
@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 9, 2020

/cherrypick enterprise-4.5

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 9, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@bobfuru: new pull request created: #22795

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bobfuru: new pull request created: #22796

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.4 branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants