Skip to content

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Jun 9, 2020

@bobfuru bobfuru added this to the Next Release milestone Jun 9, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@bobfuru bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 9, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 9, 2020

@openshift/team-documentation PTAL

@bmcelvee
Copy link
Contributor

bmcelvee commented Jun 9, 2020

LGTM - just one note, the formatting is a bit wonky on the code call-outs. "The request for a particular class by the volume snapshot.", the note, and the following call-out are tracking left of the code block. Maybe adding "+"s would help.

@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 9, 2020

LGTM - just one note, the formatting is a bit wonky on the code call-outs. "The request for a particular class by the volume snapshot.", the note, and the following call-out are tracking left of the code block. Maybe adding "+"s would help.

The + helped, thanks! Unfortunately, the note still tracks a little too far left still but it's better overall.

@bobfuru bobfuru merged commit 3bae24f into openshift:master Jun 9, 2020
@bobfuru bobfuru deleted the 1842514_master branch June 9, 2020 16:49
@bobfuru
Copy link
Contributor Author

bobfuru commented Jun 9, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@bobfuru: new pull request created: #22790

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 peer-review-needed Signifies that the peer review team needs to review this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants