Skip to content

Ocs 311 #12906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Ocs 311 #12906

merged 1 commit into from
Dec 3, 2018

Conversation

cooktheryan
Copy link

Addition of links for ocs deployment for the openshift providers that would benefit from having OCS deployed.

@netzzer

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2018
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cooktheryan, PTAL?

@kalexand-rh
Copy link
Contributor

@openshift/team-documentation PTAL? I know we're avoiding mixing modules with unmodularized content, but this might make more sense than copy/pasting the section.

@kalexand-rh kalexand-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 19, 2018
@kalexand-rh kalexand-rh mentioned this pull request Nov 20, 2018
@kalexand-rh
Copy link
Contributor

Remember that 3.10 needs this link:

https://access.redhat.com/documentation/en-us/red_hat_openshift_container_storage/3.10/html-single/deployment_guide/RHOCS[3.10 Deployment Guide].

@cooktheryan
Copy link
Author

Thanks @kalexand-rh for the review

@kalexand-rh++

@kalexand-rh
Copy link
Contributor

@openshift/team-documentation, PTAL

@mbearer
Copy link

mbearer commented Nov 30, 2018

looks good....slight editorial suggestion to this text (take it or leave it assuming still accurate):

After tagging any resources, restart the master services on the master and the node service on all nodes.

To:

After tagging any resources, restart the master services on the master and restart the node service on all nodes.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 30, 2018
@kalexand-rh
Copy link
Contributor

Thanks @mbearer! I think it's still accurate. @cooktheryan, are you up for one more edit-and-squash before I merge?

@cooktheryan
Copy link
Author

@kalexand-rh ready to go

@kalexand-rh
Copy link
Contributor

Thanks @cooktheryan! I'll merge whenever Travis finishes. :)

@kalexand-rh kalexand-rh merged commit c2756b9 into openshift:master Dec 3, 2018
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.10

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.11

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #13014

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #13015

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.10 branch/enterprise-3.11 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants