Skip to content

ocs 310 additions #12905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ocs 310 additions #12905

wants to merge 1 commit into from

Conversation

cooktheryan
Copy link

Addition of links for ocs deployment for the openshift providers that would benefit from having OCS deployed.

@netzzer

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2018
@kalexand-rh
Copy link
Contributor

@cooktheryan, on a quick scan, this looks a lot like #12906 . You could do one pr against master, and we could cherrypick it to both 3.10 and 3.11. Will you PTAL at my comments on that PR?

@cooktheryan
Copy link
Author

@kalexand-rh there is the tiniest different ever in this vs #12906

https://access.redhat.com/documentation/en-us/red_hat_openshift_container_storage/3.10/html-single/deployment_guide/RHOCS[3.10 Deployment Guide].

vs

https://access.redhat.com/documentation/en-us/red_hat_openshift_container_storage/3.11/html-single/deployment_guide/RHOCS[3.11 Deployment Guide].

If there is if statement functionality we could use that would be a huge win but not sure thats possible

@kalexand-rh
Copy link
Contributor

Gotcha. Our if statement usage doesn't cover that use case, and this is small enough usage that I don't think adding a variable makes sense. (Even if we used a variable, we'd still need different PRs to set it up.)

@cooktheryan
Copy link
Author

@kalexand-rh I just realized I'm not sure my current plan of merging this to master may not work unless we cherry-pick immediately after as both PRs will be modifying the same file on master

@kalexand-rh
Copy link
Contributor

@cooktheryan, close this one. I'll CP the other to 3.11 and then manually CP it to 3.10. I'll fix the link before I merge the 3.10 one.

@cooktheryan
Copy link
Author

@kalexand-rh++

@cooktheryan cooktheryan deleted the ocs-310 branch November 20, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants