Skip to content

OCPBUGS-52189, MCO-1626: [release-4.18] backport OCL to 4.18 #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: release-4.18
Choose a base branch
from

Conversation

cheesesashimi
Copy link
Member

- What I did

- How to verify it

- Description for the changelog
Backports OCL to 4.18.z

openshift-merge-bot bot and others added 17 commits May 1, 2025 16:47
…tests

MCO-1416: Create OCL e2e Test Suite & Remove Unneeded Helper
…tests

MCO-1416: Increase timeouts in OCL e2e tests
OCPBUGS-45496: Prevent undesired MOSBs from building
…e2e-troubleshooting

MCO-1416: Update timeouts & improve debuggability of ocl e2e tests
…rate-changes-to-helpers

MCO-1470: Incorporates upstream devex helper changes for OCL testing
NO-ISSUE: Add AUTHFILE option to make image
MCO-1437: MCO-1476: MCO-1477: MCO-1284: Adapt MCO to OCL v1 API
NO-ISSUE: Remove etc-pki-entitlement cruft
OCPBUGS-43552: maxUnavailable value is not honored when disabling OCL
No-Issue: Remove OCL Extensions test
…-43896-rebase

OCPBUGS-48810: Ensure that build jobs are always reconciled
OCPBUGS-44602: Set ownerReference for OCL build objects
…-43896

OCPBUGS-43896: add revert logic to OCL path in MCD
…-gcp-op-ocl

OCPBUGS-54161: use the same success criteria for OCL e2e tests
OCPBUGS-48675, OCPBUGS-48808, OCPBUGS-46421: Ensure build job is deleted when rebuild is triggered
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2025
Copy link
Contributor

openshift-ci bot commented May 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2025
@cheesesashimi cheesesashimi marked this pull request as ready for review May 1, 2025 21:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2025
@openshift-ci openshift-ci bot requested review from RishabhSaini and umohnani8 May 1, 2025 21:51
…xy-restoration

OCPBUGS-49894: Ensure proxy config exists when reverting from OCL to non-OCL
…-and-node-controller

OCPBUGS-53408: wait for build and ensure OS image is actually new
MCO-1558, OCPBUGS-34745: Add support to rebuild and prune OCL images
MCO-1509: Enable OCL for disconnected workflow
OCPBUGS-49675, OCPBUGS-55039: In OCL. Usbguard service fails when we install the usbguard extension: IPsec tmpfile.d directives missing when enabling IPsec in OCL
@cheesesashimi cheesesashimi force-pushed the zzlotnik/ocl-4.18-backport branch from be5acb5 to 54c4837 Compare May 2, 2025 15:03
@umohnani8
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@umohnani8
Copy link
Contributor

umohnani8 commented May 6, 2025

/retitle MCO-1626: [release-4.18] backport OCL to 4.18

@openshift-ci openshift-ci bot changed the title [release-4.18] backport OCL to 4.18 MCO-1626 [release-4.18] backport OCL to 4.18 May 6, 2025
Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cheesesashimi,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umohnani8
Copy link
Contributor

umohnani8 commented May 6, 2025

/retitle MCO-1626: [release-4.18] backport OCL to 4.18

@openshift-ci openshift-ci bot changed the title MCO-1626 [release-4.18] backport OCL to 4.18 MCO-1626: [release-4.18] backport OCL to 4.18 May 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 6, 2025

@cheesesashimi: This pull request references MCO-1626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.z" version, but no target version was set.

In response to this:

- What I did

- How to verify it

- Description for the changelog
Backports OCL to 4.18.z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umohnani8
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 6, 2025

@umohnani8: This pull request references MCO-1626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.z" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umohnani8
Copy link
Contributor

umohnani8 commented May 6, 2025

/retitle OCPBUGS-52189, MCO-1626: [release-4.18] backport OCL to 4.18

@openshift-ci openshift-ci bot changed the title MCO-1626: [release-4.18] backport OCL to 4.18 OCPBUGS-52189, MCO-1626: [release-4.18] backport OCL to 4.18 May 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 6, 2025

@cheesesashimi: This pull request references Jira Issue OCPBUGS-52189, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-44602 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-44602 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references MCO-1626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.z" version, but no target version was set.

In response to this:

- What I did

- How to verify it

- Description for the changelog
Backports OCL to 4.18.z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr May 6, 2025 13:45
@umohnani8
Copy link
Contributor

/retest

@umohnani8
Copy link
Contributor

/test e2e-gcp-op-ocl

Copy link
Contributor

openshift-ci bot commented May 7, 2025

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl 54c4837 link false /test e2e-gcp-op-ocl
ci/prow/e2e-azure-ovn-upgrade-out-of-change 54c4837 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-techpreview 54c4837 link false /test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@umohnani8
Copy link
Contributor

/testwith openshift/machine-config-operator/release-4.18/e2e-gcp-op-ocl openshift/api#2316

@umohnani8
Copy link
Contributor

/testwith openshift/machine-config-operator/release-4.18/e2e-gcp-op-techpreview openshift/api#2316

@umohnani8
Copy link
Contributor

umohnani8 commented May 8, 2025

API bump PR is openshift/api#2316 and this PR should be merged simultaneously with that one.

@umohnani8
Copy link
Contributor

/testwith openshift/machine-config-operator/release-4.18/e2e-gcp-op-ocl openshift/api#2316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.