Skip to content

NO-ISSUE: Add AUTHFILE option to make image #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

umohnani8
Copy link
Contributor

When building the mco image, add an AUTHFILE check to allow users to specify a different file from the default one for the authentication to be used during the build process.

This is something I kept having to change manually because I use a different location for my openshift auth and not the default one that podman looks at.

- What I did
Add AUTHFILE option to make image to allow specifying a file path for the auth needed during build

- How to verify it
run make image AUTHFILE=path/to/auth file and the podman build command outputed should have --authfile=path/you/specified

- Description for the changelog
Add AUTHFILE option to make image to allow specifying a file path for the auth needed during build

When building the mco image, add an AUTHFILE check to allow
users to specify a different file from the default one for the
authentication to be used during the build process.

Signed-off-by: Urvashi <umohnani@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@umohnani8
Copy link
Contributor Author

/retest

@umohnani8 umohnani8 changed the title NO ISSUE: Add AUTHFILE option to make image NO-ISSUE: Add AUTHFILE option to make image Dec 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request explicitly references no jira issue.

In response to this:

When building the mco image, add an AUTHFILE check to allow users to specify a different file from the default one for the authentication to be used during the build process.

This is something I kept having to change manually because I use a different location for my openshift auth and not the default one that podman looks at.

- What I did
Add AUTHFILE option to make image to allow specifying a file path for the auth needed during build

- How to verify it
run make image AUTHFILE=path/to/auth file and the podman build command outputed should have --authfile=path/you/specified

- Description for the changelog
Add AUTHFILE option to make image to allow specifying a file path for the auth needed during build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f0d60f5 and 2 for PR HEAD 3ac848a in total

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@umohnani8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3ac848a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change 3ac848a link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 53cdf40 and 1 for PR HEAD 3ac848a in total

@openshift-merge-bot openshift-merge-bot bot merged commit 599f6cd into openshift:master Jan 7, 2025
17 of 19 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202501071907.p0.g599f6cd.assembly.stream.el9.
All builds following this will include this PR.

cheesesashimi pushed a commit to cheesesashimi/machine-config-operator that referenced this pull request May 1, 2025
NO-ISSUE: Add AUTHFILE option to make image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants