Skip to content

OCPEDGE-1310: feat: add arbiter node support to installer #9159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Mar 1, 2025
Merged

OCPEDGE-1310: feat: add arbiter node support to installer #9159

openshift-merge-bot merged 1 commit into from
Mar 1, 2025

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Oct 31, 2024 •
edited
Loading

Added initial support for the arbiter node installation path for baremetal.

The arbiter node is similar to the master node and is part of the control plane but will be used for smaller hardware sizes. Currently this is a TechPreview feature and only supported on baremetal.

For more details see EP: openshift/enhancements#1674

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@openshift-ci openshift-ci bot requested review from andfasano and rwsu October 31, 2024 05:54
@andfasano andfasano mentioned this pull request Oct 31, 2024
Merged
@eggfoobar eggfoobar force-pushed the add-arbiter-node branch 2 times, most recently from f79207b to 9e40e69 Compare November 5, 2024 17:50
@eggfoobar eggfoobar mentioned this pull request Nov 8, 2024
Merged
9 tasks
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@eggfoobar eggfoobar force-pushed the add-arbiter-node branch 3 times, most recently from 443123d to ec69e09 Compare November 18, 2024 01:10
@eggfoobar eggfoobar changed the title WIP: feat: add arbiter node support to installer WIP: OCPEDGE-1310: feat: add arbiter node support to installer Nov 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1310 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@eggfoobar eggfoobar force-pushed the add-arbiter-node branch 3 times, most recently from 7da114c to fc58f45 Compare November 19, 2024 04:07
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2024
@eggfoobar eggfoobar force-pushed the add-arbiter-node branch 2 times, most recently from 4a90dee to 59784e7 Compare November 22, 2024 21:29
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2024
@eggfoobar eggfoobar force-pushed the add-arbiter-node branch 2 times, most recently from c7bfc21 to 83e903e Compare December 13, 2024 05:00
@eggfoobar eggfoobar force-pushed the add-arbiter-node branch 4 times, most recently from 8ec9251 to 25fb9cd Compare January 17, 2025 15:28
@eggfoobar eggfoobar changed the title WIP: OCPEDGE-1310: feat: add arbiter node support to installer OCPEDGE-1310: feat: add arbiter node support to installer Jan 17, 2025
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 20, 2025

/retest-required

@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 25, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2025

/retest-required

Remaining retests: 0 against base HEAD 282df04 and 2 for PR HEAD 068689c in total

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 26, 2025

/retest-required

2 similar comments
@suleymanakbas91
Copy link

suleymanakbas91 commented Feb 26, 2025

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 26, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2025

/retest-required

Remaining retests: 0 against base HEAD e26b7ff and 2 for PR HEAD 068689c in total

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 27, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2025

/retest-required

Remaining retests: 0 against base HEAD 3612909 and 1 for PR HEAD 068689c in total

@qJkee
Copy link
Contributor

qJkee commented Feb 27, 2025

/retest-required

1 similar comment
@suleymanakbas91
Copy link

suleymanakbas91 commented Feb 27, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2025

/retest-required

Remaining retests: 0 against base HEAD 3612909 and 2 for PR HEAD 068689c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2025

/retest-required

Remaining retests: 0 against base HEAD 6bc5c21 and 2 for PR HEAD 068689c in total

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 28, 2025

/retest-required

7 similar comments
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 28, 2025

/retest-required

@qJkee
Copy link
Contributor

qJkee commented Feb 28, 2025

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 28, 2025

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 28, 2025

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 28, 2025

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 28, 2025

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Mar 1, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2025 •
edited
Loading

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-unit 59784e789b55fdaa23dee9eb05f03bce8030bf58 link true /test okd-unit
ci/prow/okd-verify-codegen 59784e789b55fdaa23dee9eb05f03bce8030bf58 link true /test okd-verify-codegen
ci/prow/e2e-aws-ovn-upi 83e903e1f32ca9b54a5a3738f2276263d6fb58b3 link true /test e2e-aws-ovn-upi
ci/prow/e2e-vsphere-ovn-upi 83e903e1f32ca9b54a5a3738f2276263d6fb58b3 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-azure-ovn-upi 83e903e1f32ca9b54a5a3738f2276263d6fb58b3 link true /test e2e-azure-ovn-upi
ci/prow/e2e-gcp-ovn-upi 83e903e1f32ca9b54a5a3738f2276263d6fb58b3 link true /test e2e-gcp-ovn-upi
ci/prow/e2e-azurestack 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-azurestack
ci/prow/e2e-gcp-ovn-xpn 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-openstack-proxy 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-openstack-proxy
ci/prow/e2e-azure-ovn-shared-vpc 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-vsphere-ovn-techpreview 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-vsphere-ovn 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-default-config 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-gcp-default-config
ci/prow/e2e-openstack-ovn 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link true /test e2e-openstack-ovn
ci/prow/e2e-azure-default-config 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-azure-default-config
ci/prow/e2e-gcp-ovn 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-multi-vcenter-ovn 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-vsphere-multi-vcenter-ovn
ci/prow/e2e-vsphere-ovn-zones-techpreview 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-vsphere-ovn-zones-techpreview
ci/prow/e2e-vsphere-ovn-zones 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link false /test e2e-vsphere-ovn-zones
ci/prow/openstack-manifests 7e96218e2d4481f52e49dccf1e9d7728e46b3358 link true /test openstack-manifests
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones f942f4fe943ef2fc672d90209e947ffaecc4ae49 link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade 26c9b19670bd76b10bb206cd947fba6614f36068 link false /test e2e-vsphere-host-groups-ovn-custom-no-upgrade
ci/prow/e2e-metal-single-node-live-iso 068689c link false /test e2e-metal-single-node-live-iso
ci/prow/okd-scos-e2e-aws-ovn 068689c link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-assisted 068689c link false /test e2e-metal-assisted

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Mar 1, 2025

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit e9b3cf7 into openshift:main Mar 1, 2025
34 of 37 checks passed
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202503010809.p0.ge9b3cf7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202503010809.p0.ge9b3cf7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202503010809.p0.ge9b3cf7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202503010809.p0.ge9b3cf7.assembly.stream.el9.
All builds following this will include this PR.

@giladravid16 giladravid16 mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaneb zaneb zaneb left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@andfasano andfasano Awaiting requested review from andfasano

@rwsu rwsu Awaiting requested review from rwsu

+1 more reviewer

@dtantsur dtantsur dtantsur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@eggfoobar @openshift-ci-robot @suleymanakbas91 @patrickdillon @qJkee @openshift-bot @dtantsur @zaneb @openshift-merge-robot