Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vSphere IPI #154

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Add vSphere IPI #154

merged 1 commit into from
Jan 22, 2021

Conversation

jcpowermac
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2019
@jcpowermac jcpowermac mentioned this pull request Dec 19, 2019
Merged
mtnbikenc
mtnbikenc reviewed Dec 19, 2019
View reviewed changes
enhancements/installer/vsphere-ipi.md Outdated
- Does vsphere need any metadata changes:
- `pkg/asset/cluster/vsphere`
- `pkg/asset/cluster/vsphere/vsphere.go`
- Do we need to create resource pools?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.redhat.com/browse/CORS-1329

@jcpowermac
Copy link
Contributor Author

@sdodson
@abhinavdahiya
What are we critically missing from this?

@dav1x when you get a chance if you can take a look as well.

enxebre
enxebre reviewed Dec 20, 2019
View reviewed changes
enhancements/installer/vsphere-ipi.md
- Custom placement of the VM template
- Custom name of the VM template
- `pkg/rhcos/vsphere.go`
- Add machines and machinesets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developing for the machine API is happening here
API
https://github.com/openshift/machine-api-operator/tree/master/pkg/apis/vsphereprovider
Controller
https://github.com/openshift/machine-api-operator/tree/master/pkg/controller/vsphere

We'll start by supporting only vCenter interactions (no raw esxi) and only supporting cloning templates on "creation". We'll extend this behaviour later on only if there's a product requirement.

We are assuming the existence of a secret with a user and password keys used to login against the vCenter https://github.com/openshift/machine-api-operator/blob/master/pkg/controller/vsphere/machine_scope.go#L57

@jcpowermac jcpowermac mentioned this pull request Jan 10, 2020
Merged
@markmc markmc mentioned this pull request May 9, 2020
Merged
@russellb
Copy link
Member

@jcpowermac I know vSphere IPI support has already merged. Can you help make sure this enhancement is updated to reflect what has been done and then we'll merge it to reflect the current state of things? Thanks!

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 11, 2020
@sdodson
Copy link
Member

sdodson commented Dec 14, 2020

@jcpowermac I know vSphere IPI support has already merged. Can you help make sure this enhancement is updated to reflect what has been done and then we'll merge it to reflect the current state of things? Thanks!

@jcpowermac bump on this, can we do a quick review to make sure there aren't significant deviations between this enhancement and what's actually been implemented and then merge it?

@sdodson
Copy link
Member

sdodson commented Dec 14, 2020

/remove-lifecycle rotten

@openshift-ci-robot openshift-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 14, 2020
@russellb
Copy link
Member

@jcpowermac bump. :-) (also pinged on slack)

@jcpowermac
Add vSphere IPI
e149501 
This is generally up-to-date, there might have been minor changes
from when this document was written til now.

vSphere IPI continues to use kni aka baremetal networking services.

The CI section is out of date, we only use VMC (VMware on AWS) now.
That can be updated later
@jcpowermac jcpowermac changed the title [wip] Add vSphere IPI Add vSphere IPI Jan 22, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2021
@russellb
Copy link
Member

@jcpowermac says this is close enough and that the CI section is the most out of date. We should just merge as is.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2021
@russellb
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6fd58fb into openshift:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@mtnbikenc mtnbikenc mtnbikenc left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@russellb russellb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jcpowermac @russellb @openshift-bot @sdodson @openshift-ci-robot @enxebre @mtnbikenc @openshift-merge-robot