-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding terraform for vSphere IPI; changes to tfvars to support it #2841
Conversation
Terraform needs to be tested |
@dav1x @mtnbikenc can you guys take an initial look |
ignition_encoded = "data:text/plain;charset=utf-8;base64,${base64encode(var.ignition)}" | ||
} | ||
|
||
data "ignition_file" "hostname" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the machine-api is to recreate the machine, how will it recreate this behavior?
cb80e3f
to
407d9de
Compare
|
||
data "ignition_file" "hostname" { | ||
count = var.instance_count | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need static ignition config here? post cluster creation we should be able to create a valid master instance via API by relying only on the ignition config served by the mco (machine config operator).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enxebre not sure how else we would set the hostname of the control plane nodes which is required for "baremetal networking" which we are using with vSphere IPI.
https://github.com/openshift/enhancements/pull/148/files#diff-141f756d80782cc4aa106f6b3d264f2dR208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the template's linux-costomization-options to set hostname?
https://www.terraform.io/docs/providers/vsphere/r/virtual_machine.html#linux-customization-options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstuever that would certainly make it easier. Looks like it requires perl.
https://docs.vmware.com/en/VMware-vSphere/6.7/com.vmware.vsphere.vm_admin.doc/GUID-E63B6FAA-8D35-428D-B40C-744769845906.html#GUID-E63B6FAA-8D35-428D-B40C-744769845906
KB article regarding CoreOS specifically says:
"Guest Customization of CoreOS from vCenter or vCloud Director is not supported."
https://kb.vmware.com/s/article/2109161
Not surpising the guest guide doesn't mention RHCOS:
https://www.vmware.com/resources/compatibility/pdf/VMware_GOS_Compatibility_Guide.pdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a shame... I was hoping maybe it was using DHCP trickery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the host look itself via mDNS and set its hostname that way? This certainly seems like a tricky problem to solve. I'm inclined to suggest we move forward but make sure to track this as something we must figure out
I don't know how close we are to realistically being able to replace control plane hosts today outside of this specific concern. @enxebre do you know?
/hold cancel |
This PR: #2861 |
/hold cancel |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/skip |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/skip |
/retest Please review the full test history for this PR and help us cut down flakes. |
Added tags to vSphere vCenter objects that will need to be destroyed. Removed the ability to create a resource pool. Using the cluster default RP inplace. The customer can move the machines to a properly configured RP if so desired.
/lgtm |
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/skip |
This change adds the terraform to create bootstrap and control plane nodes for vSphere IPI.
Adds vSphere tfvars.