Bug 2088304: Eliminate use of lookaside cache and move to Cachito #11497
Conversation
[Legacy Container First Pipeline][1] will be deprecated on Jun 3, 2022. Images failing to migrate to the new source container workflow by this date will not have their sources shipped to customers and lose the compliance with legal requirements. To move to the new source container workflow, we need to: - Eliminate use of distgit lookaside cache, which is not supported by the new workflow. - Use [Cachito][2] to track and provide npm dependencies. - Use [fetch-artifacts-url.yaml][3] to fetch binaries artifacts during the build. Due to a limitation in Cachito, we also need to give a pseudo name and version to the frontend package. AFAIK the version doesn't need to be unique for every build. I am not familiar with the code base. Let me know if the change is legitimate. [1]: https://docs.engineering.redhat.com/display/SP/Decommission+of+Legacy+Container+First+Pipeline [2]: https://github.com/containerbuildsystem/cachito [3]: https://osbs.readthedocs.io/en/osbs_ocp3/users.html#fetch-artifacts-url-yaml
|
This PR needs to wait on https://issues.redhat.com/browse/CLOUDBLD-9948. |
openshift-ci
bot
added
the
do-not-merge/hold
|
I think this should be fine, although we'll have to dig in to see what is causing the lint failure. |
|
cc @bipuladh since these are tsdoc lint failures |
|
Thanks for the review. I created a test build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=45345673, could anyone have a look to ensure we won't break things? I moved the artifacts that previously stored on lookaside cache to http://download.eng.bos.redhat.com/rcm-guest/puddles/RHAOS/artifacts/build-deps/, and used the following - target: yarn-v1.22.19.tar.gz
url: http://download.eng.bos.redhat.com/rcm-guest/puddles/RHAOS/artifacts/build-deps/yarn-v1.22.19.tar.gz
sha256: 732620bac8b1690d507274f025f3c6cfdc3627a84d9642e38a07452cc00e0f2e
source-url: http://download.eng.bos.redhat.com/rcm-guest/puddles/RHAOS/artifacts/build-deps/yarn-source-v1.22.19.tar.gz
source-sha256: 50af0025d2ef942bf3e6cdd0587dc9c4dd8d6e6e69501b84935d09f2b2b5de8b |
|
@vfreex: once the present PR merges, I will cherry-pick it on top of openshift-4.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/hold
Using distgit lookaside cache will not be allowed in the new source container workflow. This PR: - Uses OSBS fetch-artifacts-url.yaml to instruct OSBS to download the binaries from the internal web server during build. - Uses Cachito to provide npm dependencies. Requires: - openshift/console#11497 - openshift-eng/doozer#594 - openshift-eng/doozer#593
|
/cherry-pick release-4.11 |
|
@vfreex: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
frontend/packages/console-plugin-sdk/src/codegen/plugin-resolver.ts
Outdated
Show resolved
Hide resolved
I can see tsdoc warns but the ferror is related to prettier. |
…er.ts Co-authored-by: Bipul Adhikari <badhikar@redhat.com>
|
@vfreex I was able to pull and run the image from your test build. It looks good to me 👍 |
|
/approve |
openshift-ci
bot
added
the
approved
|
/retest |
Thank you. Any idea about the CI failure? I will also create another PR for 4.6-4.9. |
It looks like you still need to run prettier on plugin-resolver.ts |
vfreex
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@vfreex: This pull request references Bugzilla bug 2088304, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@vfreex: This pull request references Bugzilla bug 2088304, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Done fixing the lint issue. Seems all tests passed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, vfreex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@vfreex: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@vfreex: All pull requests linked via external trackers have merged: Bugzilla bug 2088304 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vfreex: new pull request created: #11550 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vfreex: new pull request created: #11551 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using distgit lookaside cache will not be allowed in the new source container workflow. This PR: - Uses OSBS fetch-artifacts-url.yaml to instruct OSBS to download the binaries from the internal web server during build. - Uses Cachito to provide npm dependencies. Requires: - openshift/console#11497 - openshift-eng/doozer#594 - openshift-eng/doozer#593
Legacy Container First Pipeline will be deprecated on Jun 3, 2022. Images failing to migrate to the new source container workflow by this date will not have their sources shipped to customers and lose the compliance with legal requirements.
To move to the new source container workflow, we need to:
Due to a limitation in Cachito, we also need to give a pseudo name and version to the frontend package. AFAIK the version doesn't need to be unique for every build.
I am not familiar with the code base. Let me know if the change is legitimate.