Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ose-console: Get rid of distgit lookaside cache #1608

Merged
merged 2 commits into from
May 24, 2022

Conversation

vfreex
Copy link
Contributor

@vfreex vfreex commented May 17, 2022

Using distgit lookaside cache will not be allowed in the new source container workflow.

This PR:

  • Uses OSBS fetch-artifacts-url.yaml to instruct OSBS to download the binaries from the internal web server during build.
  • Uses Cachito to provide npm dependencies.

Requires:

Using distgit lookaside cache will not be allowed in the new source container workflow.

This PR:
- Uses OSBS fetch-artifacts-url.yaml to instruct OSBS to download the binaries from the internal web server during build.
- Uses Cachito to provide npm dependencies.

Requires:
- openshift/console#11497
- openshift-eng/doozer#594
- openshift-eng/doozer#593
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@vfreex: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

ose-console: Get rid of distgit lookaside cache

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Build #1

Validating 1 file(s)...
Schema mismatch: images/openshift-enterprise-console.yml
Returned error: Key 'content' error:
Key 'source' error:
Key 'pkg_managers' error:
Or(And(<class 'str'>, <built-in function len>, <function <lambda> at 0x7f0032e04400>)) did not validate 'yarn'
<lambda>('yarn') should evaluate to True

@vfreex
Copy link
Contributor Author

vfreex commented May 17, 2022

openshift-eng/ocp-build-data-validator#67 to add yarn as a valid package manager.

@vfreex
Copy link
Contributor Author

vfreex commented May 17, 2022

/cherry-pick openshift-4.10

@openshift-cherrypick-robot

@vfreex: once the present PR merges, I will cherry-pick it on top of openshift-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick openshift-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Build #2

Validating 1 file(s)...
Schema mismatch: images/openshift-enterprise-console.yml
Returned error: Key 'content' error:
Key 'source' error:
Key 'pkg_managers' error:
Or(And(<class 'str'>, <built-in function len>, <function <lambda> at 0x7f88aca5d400>)) did not validate 'yarn'
<lambda>('yarn') should evaluate to True

@openshift-bot
Copy link

Build #3

Validating 1 file(s)...
Schema mismatch: images/openshift-enterprise-console.yml
Returned error: Key 'content' error:
Key 'source' error:
Key 'pkg_managers' error:
Or(And(<class 'str'>, <built-in function len>, <function <lambda> at 0x7fe95cff1400>)) did not validate 'yarn'
<lambda>('yarn') should evaluate to True

@openshift-bot
Copy link

Build #4

Validating 1 file(s)...
Schema mismatch: images/openshift-enterprise-console.yml
Returned error: Key 'content' error:
Key 'source' error:
Key 'pkg_managers' error:
Or(And(<class 'str'>, <built-in function len>, <function <lambda> at 0x7f4a71547400>)) did not validate 'yarn'
<lambda>('yarn') should evaluate to True

@openshift-bot
Copy link

Build #5

Validating 1 file(s)...
Schema mismatch: images/openshift-enterprise-console.yml
Returned error: Key 'content' error:
Key 'source' error:
Key 'pkg_managers' error:
Or(And(<class 'str'>, <built-in function len>, <function <lambda> at 0x7f08d58e1400>)) did not validate 'yarn'
<lambda>('yarn') should evaluate to True

@openshift-bot
Copy link

Build #6

Validating 1 file(s)...
Schema mismatch: images/openshift-enterprise-console.yml
Returned error: Key 'content' error:
Key 'source' error:
Key 'pkg_managers' error:
Or(And(<class 'str'>, <built-in function len>, <function <lambda> at 0x7fcd5214f400>)) did not validate 'yarn'
<lambda>('yarn') should evaluate to True

@openshift-bot
Copy link

Build #7

Validating 1 file(s)...
Schema mismatch: images/openshift-enterprise-console.yml
Returned error: Key 'content' error:
Key 'source' error:
Key 'pkg_managers' error:
Or(And(<class 'str'>, <built-in function len>, <function <lambda> at 0x7f86109bc400>)) did not validate 'yarn'
<lambda>('yarn') should evaluate to True

@joepvd
Copy link
Contributor

joepvd commented May 24, 2022

/lgtm

(but let's wait for the other PRs to merge etc)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@vfreex
Copy link
Contributor Author

vfreex commented May 24, 2022

Doozer bumped. Merging

@openshift-cherrypick-robot

@vfreex: new pull request created: #1625

In response to this:

/cherry-pick openshift-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants