[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

[christoph-jerolimov]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2084028

Revert hot-fix #11256 and manual backport of #11382 for 4.9

• [release-4.10] Bug 2077641: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls #11382
• Bug 2073437: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls #11307

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2084028, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2077641 is in the state RELEASE_PENDING, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2077641 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.10] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christoph-jerolimov]

/cc @rottencandy @invincibleJai

[rottencandy]

Tested on cluster, firehose calls work as expected and caching still works without issues.
Code changes also look good.
/lgtm

0.mp4

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[christoph-jerolimov]

/label backport-risk-assessed
/cc @sanketpathak

[sanketpathak]

/label cherry-pick-approved

[openshift-ci]

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#11476

Bugzilla bug 2084028 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2084028: Improve Firehose cache, so that it does not return unexpected data also if isList differs on two concurrent calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christoph-jerolimov]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@jerolimov: #11476 failed to apply on top of branch "release-4.8":

Applying: Revert "return process data as array for list true in firehose as done in hooks"
Using index info to reconstruct a base tree...
M	frontend/public/components/utils/__tests__/firehose.spec.tsx
M	frontend/public/components/utils/firehose.jsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/utils/__tests__/firehose.spec.tsx
No changes -- Patch already applied.
Applying: Add unit tests to test Firehose and useK8sWatchResources together
Using index info to reconstruct a base tree...
M	frontend/public/components/utils/__tests__/firehose.spec.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/utils/__tests__/firehose.spec.tsx
CONFLICT (content): Merge conflict in frontend/public/components/utils/__tests__/firehose.spec.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Add unit tests to test Firehose and useK8sWatchResources together
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.