Do not fetch all secrets if there is no secret name

openshift · May 11, 2022 · d859458 · d859458
1 parent 80372ef
commit d859458
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/frontend/packages/dev-console/src/components/import/git/SourceSecretSelector.tsx b/frontend/packages/dev-console/src/components/import/git/SourceSecretSelector.tsx
@@ -21,13 +21,17 @@ const SourceSecretSelector: React.FC<{
   const { values, setFieldValue } = useFormikContext<FormikValues>();
   const namespace: string = _.get(values, `${fieldPrefix}project.name`);
   const secret: string = _.get(values, `${fieldPrefix}git.secret`);
-  const [data, loaded, loadError] = useK8sWatchResource({
-    kind: SecretModel.kind,
-    namespace,
-    name: secret,
-    optional: true,
-    isList: false,
-  });
+  const [data, loaded, loadError] = useK8sWatchResource(
+    namespace && secret
+      ? {
+          kind: SecretModel.kind,
+          namespace,
+          name: secret,
+          optional: true,
+          isList: false,
+        }
+      : null,
+  );
 
   const handleSave = (name: string) => {
     setFieldValue(`${fieldPrefix}git.secret`, name);