Skip to content

Bug 2113936: e2e: check for tsc=reliable instead of tsc=nowatchdog #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Aug 2, 2022

Recent TuneD realtime profile is using tsc=reliable
instead of tsc=nowatchdog. Adjust
[reboots][machine_config_labels] to reflect this. See:
redhat-performance/tuned#423

Signed-off-by: Jiri Mencak jmencak@users.noreply.github.com

Recent TuneD realtime profile is using tsc=reliable
instead of tsc=nowatchdog.  Adjust
[reboots][machine_config_labels] to reflect this.  See:
redhat-performance/tuned#423

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from dagrayvid and Tal-or August 2, 2022 07:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@jmencak
Copy link
Contributor Author

jmencak commented Aug 2, 2022

/cc @yanirq

@ffromani
Copy link
Contributor

ffromani commented Aug 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@ffromani
Copy link
Contributor

ffromani commented Aug 2, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@yanirq
Copy link
Contributor

yanirq commented Aug 2, 2022

do we still to maintain and align the assets ? e.g.

cmdline_realtime=+isolcpus=${managed_irq}${isolated_cores} intel_pstate=disable nosoftlockup tsc=nowatchdog

@ffromani
Copy link
Contributor

ffromani commented Aug 2, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 285eec9 into openshift:master Aug 2, 2022
@jmencak
Copy link
Contributor Author

jmencak commented Aug 2, 2022

/cherry-pick release-4.11
/cherry-pick release-4.10

@openshift-cherrypick-robot

@jmencak: new pull request created: #411

In response to this:

/cherry-pick release-4.11
/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.12-e2e-tests-realtime branch August 2, 2022 10:49
@jmencak jmencak changed the title e2e: check for tsc=reliable instead of tsc=nowatchdog Bug 2113936: e2e: check for tsc=reliable instead of tsc=nowatchdog Aug 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@jmencak: All pull requests linked via external trackers have merged:

Bugzilla bug 2113936 has been moved to the MODIFIED state.

In response to this:

Bug 2113936: e2e: check for tsc=reliable instead of tsc=nowatchdog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
Recent TuneD realtime profile is using tsc=reliable
instead of tsc=nowatchdog.  Adjust
[reboots][machine_config_labels] to reflect this.  See:
redhat-performance/tuned#423

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
Recent TuneD realtime profile is using tsc=reliable
instead of tsc=nowatchdog.  Adjust
[reboots][machine_config_labels] to reflect this.  See:
redhat-performance/tuned#423

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants