Skip to content

Bug 2102450: set rcutree.kthread_prio to ksoftirqd prio #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

vitus133
Copy link
Contributor

When a performance profile is applied, the priority of the
ksoftirqd and rcuc realtime attributes are set to to FIFO:11.
The rcutree.kthread_prio must be set accordingly to avoid
RCU stall situations with rt kernel

Signed-off-by: Vitaly Grinberg vgrinber@redhat.com

When a performance profile is applied, the priority of the
ksoftirqd and rcuc realtime attributes are set to to FIFO:11.
The rcutree.kthread_prio must be set accordingly to avoid
RCU stall situations with rt kernel

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2022

@vitus133: This pull request references Bugzilla bug 2102450, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

Bug 2102450: set rcutree.kthread_prio to ksoftirqd prio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gsr-shanks July 31, 2022 06:18
@vitus133
Copy link
Contributor Author

/assign @yanirq

@openshift-ci openshift-ci bot requested review from Tal-or and yanirq July 31, 2022 06:18
@yanirq
Copy link
Contributor

yanirq commented Aug 1, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@ffromani
Copy link
Contributor

ffromani commented Aug 1, 2022

/retest-required

@vitus133
Copy link
Contributor Author

vitus133 commented Aug 1, 2022

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 2b8674b and 8 for PR HEAD ad1750d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 2b8674b and 7 for PR HEAD ad1750d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2b8674b and 6 for PR HEAD ad1750d in total

@vitus133
Copy link
Contributor Author

vitus133 commented Aug 2, 2022

/retest-required

@yanirq
Copy link
Contributor

yanirq commented Aug 2, 2022

I think we are hitting a test error in the operator lane due to redhat-performance/tuned#423
we should align the test ([reboots][machine_config_labels] Node Tuning Operator machine config labels) and re-asses the values we set for the performance profile.
(cc @MarSik @jmencak )

@jmencak
Copy link
Contributor

jmencak commented Aug 2, 2022

I think we are hitting a test error in the operator lane due to redhat-performance/tuned#423 we should align the test ([reboots][machine_config_labels] Node Tuning Operator machine config labels) and re-asses the values we set for the performance profile. (cc @MarSik @jmencak )

Thank you Yanir. Fix in: #410

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 285eec9 and 5 for PR HEAD ad1750d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 285eec9 and 4 for PR HEAD ad1750d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 47762ba into openshift:master Aug 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@vitus133: All pull requests linked via external trackers have merged:

Bugzilla bug 2102450 has been moved to the MODIFIED state.

In response to this:

Bug 2102450: set rcutree.kthread_prio to ksoftirqd prio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vitus133
Copy link
Contributor Author

vitus133 commented Aug 3, 2022

/cherrypick release-4.11

@openshift-cherrypick-robot

@vitus133: new pull request created: #414

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
When a performance profile is applied, the priority of the
ksoftirqd and rcuc realtime attributes are set to to FIFO:11.
The rcutree.kthread_prio must be set accordingly to avoid
RCU stall situations with rt kernel

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
When a performance profile is applied, the priority of the
ksoftirqd and rcuc realtime attributes are set to to FIFO:11.
The rcutree.kthread_prio must be set accordingly to avoid
RCU stall situations with rt kernel

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants