Skip to content

CNF-16459: Update cnf-tests image #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CNF-16459: Update cnf-tests image #1286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/performanceprofile/functests/utils/images/images.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ func init() {
cnfTestsImage = os.Getenv("CNF_TESTS_IMAGE")

if cnfTestsImage == "" {
cnfTestsImage = "cnf-tests:4.14"
cnfTestsImage = "cnf-tests:4.19"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a fix that does not hardcode the image version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is actually hard to do here, the source has no way to find out the version of a build from a different repo. That is why the env var is here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the fallback default, it's a fair assumption to go in lockstop with the NTO branch/version. The existing env var can and should be used for fine tuning, leaving the hardcoded value to sane defaults.

}

if registry == "" {
Expand Down