CNF-16459: Update cnf-tests image #1286
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rbaturov: This pull request references CNF-16459 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve but we would need some form of automation to make sure images are kept up to date |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, rbaturov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Yes I'm thinking how this is going to be done |
I just realized we were already branched out from 4.18. Will update the PR to point this image to 4.19 instead. |
Corrected the cnf-tests image to point to the correct image version of this release. Signed-off-by: Ronny Baturov <rbaturov@redhat.com>
rbaturov
force-pushed
the
fix-cnf-tests-image-version
branch
from
f7de46e to
0dc0443
Compare
|
/lgtm |
We'll probably add a lane to validate that the specified image is aligned with the branch version |
| @@ -13,7 +13,7 @@ func init() { | |||
| cnfTestsImage = os.Getenv("CNF_TESTS_IMAGE") | |||
|
|
|||
| if cnfTestsImage == "" { | |||
| cnfTestsImage = "cnf-tests:4.14" | |||
| cnfTestsImage = "cnf-tests:4.19" | |||
There was a problem hiding this comment.
We need a fix that does not hardcode the image version.
There was a problem hiding this comment.
That is actually hard to do here, the source has no way to find out the version of a build from a different repo. That is why the env var is here.
There was a problem hiding this comment.
this is the fallback default, it's a fair assumption to go in lockstop with the NTO branch/version. The existing env var can and should be used for fine tuning, leaving the hardcoded value to sane defaults.
|
What about this hardcoded (and outdated) reference to a specific commit in the cluster-node-tuning repo (where some of the test code resides): |
As far as I understood, we don't run tests from this vendored repo. |
There was a problem hiding this comment.
The CI won't pass.
This is because of:
libhugetlbfs.so is no longer exist in cnf-tests:4.19
We should fix the test similar to what was done in:
openshift-kni/cnf-features-deploy@b8df9f2
|
@rbaturov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR corrects the cnf-tests image to point to the correct image version of this release.
We plan to create a corresponding PR for this down to 4.14 at least.