Skip to content

OCPCLOUD-3042: use go workspace#376

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
sunzhaohua2:gowork
Nov 21, 2025
Merged

OCPCLOUD-3042: use go workspace#376
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
sunzhaohua2:gowork

Conversation

@sunzhaohua2
Copy link
Contributor

After #372 merged, art team found the image failed to build due to dependency. The build failures like:

cmd/main.go:23:2: github.com/openshift-eng/openshift-tests-extension@v0.0.0-20251024155203-c498f9efe478: 
reading file:///cachi2/output/deps/gomod/pkg/mod/cache/download/...no such file or directory

I checked with claude, seems Cachi2 only scans the main go.mod file for dependencies, so this add go.work file to include the main module and the openshift-tests-extension submodule. This allows Cachi2 to scan all modules' dependencies.

slack: https://redhat-internal.slack.com/archives/CB95J6R4N/p1763366654248019

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2025

@sunzhaohua2: This pull request references OCPCLOUD-3042 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

After #372 merged, art team found the image failed to build due to dependency. The build failures like:

cmd/main.go:23:2: github.com/openshift-eng/openshift-tests-extension@v0.0.0-20251024155203-c498f9efe478: 
reading file:///cachi2/output/deps/gomod/pkg/mod/cache/download/...no such file or directory

I checked with claude, seems Cachi2 only scans the main go.mod file for dependencies, so this add go.work file to include the main module and the openshift-tests-extension submodule. This allows Cachi2 to scan all modules' dependencies.

slack: https://redhat-internal.slack.com/archives/CB95J6R4N/p1763366654248019

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2025
@sunzhaohua2
Copy link
Contributor Author

/retest

1 similar comment
@sunzhaohua2
Copy link
Contributor Author

/retest

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

One question

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

For testing to pass

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@damdo
Copy link
Member

damdo commented Nov 20, 2025

/retest-required

@sunzhaohua2
Copy link
Contributor Author

/retest

1 similar comment
@sunzhaohua2
Copy link
Contributor Author

/retest

@sunzhaohua2
Copy link
Contributor Author

/retest-required

@damdo
Copy link
Member

damdo commented Nov 21, 2025

@sunzhaohua2 the required ci/prow/e2e-aws-ovn-etcd-scaling, passed here but failed the Degraded=True blip check, which we know happens all the time in the CPMSO due to #357

/override ci/prow/e2e-aws-ovn-etcd-scaling

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-ovn-etcd-scaling

Details

In response to this:

@sunzhaohua2 the required ci/prow/e2e-aws-ovn-etcd-scaling, passed here but failed the Degraded=True blip check, which we know happens all the time in the CPMSO due to #357

/override ci/prow/e2e-aws-ovn-etcd-scaling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Nov 21, 2025

Not sure why the openstack jobs are failing though.
It looks like timeouts to me, could anyone confirm @stephenfin @pierreprinetti ? TY

@damdo
Copy link
Member

damdo commented Nov 21, 2025

/override ci/prow/e2e-azure-ovn-etcd-scaling ci/prow/e2e-gcp-ovn-etcd-scaling ci/prow/e2e-vsphere-ovn-etcd-scaling

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-azure-ovn-etcd-scaling, ci/prow/e2e-gcp-ovn-etcd-scaling, ci/prow/e2e-vsphere-ovn-etcd-scaling

Details

In response to this:

/override ci/prow/e2e-azure-ovn-etcd-scaling ci/prow/e2e-gcp-ovn-etcd-scaling ci/prow/e2e-vsphere-ovn-etcd-scaling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Nov 21, 2025

/test e2e-openstack-operator

@damdo
Copy link
Member

damdo commented Nov 21, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025
@damdo
Copy link
Member

damdo commented Nov 21, 2025

Openstack jobs will get investigated separately here, they should not block this: https://redhat-internal.slack.com/archives/CBZHF4DHC/p1763715507731489?thread_ts=1763715435.042349&cid=CBZHF4DHC

@damdo
Copy link
Member

damdo commented Nov 21, 2025

This is not a functional change, only the addition of go workspaces.

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 21, 2025
@openshift-ci-robot
Copy link

@damdo: The verified label has been added.

Details

In response to this:

This is not a functional change, only a the addition of go workspaces.

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2220a43 and 2 for PR HEAD 9701e6b in total

@damdo
Copy link
Member

damdo commented Nov 21, 2025

/override ci/prow/e2e-aws-ovn-etcd-scaling

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-ovn-etcd-scaling

Details

In response to this:

/override ci/prow/e2e-aws-ovn-etcd-scaling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 231a1fc into openshift:main Nov 21, 2025
35 of 39 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

@sunzhaohua2: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-nutanix-ovn 9701e6b link false /test e2e-nutanix-ovn
ci/prow/e2e-openstack-periodic-pre-techpreview 9701e6b link false /test e2e-openstack-periodic-pre-techpreview
ci/prow/e2e-openstack-periodic-pre 9701e6b link false /test e2e-openstack-periodic-pre

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants