Skip to content

WIP: add unmanaged grace period for new node#357

Draft
damdo wants to merge 3 commits intoopenshift:mainfrom
damdo:add-unmanaged-grace-period-for-new-node
Draft

WIP: add unmanaged grace period for new node#357
damdo wants to merge 3 commits intoopenshift:mainfrom
damdo:add-unmanaged-grace-period-for-new-node

Conversation

@damdo
Copy link
Member

@damdo damdo commented Apr 7, 2025

Add unmanaged grace period for new node to avoid going immediately degraded if a node has just been created and hasn't been linked to a machine yet.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2025
@damdo damdo force-pushed the add-unmanaged-grace-period-for-new-node branch from f589af4 to aa2e7c7 Compare April 7, 2025 08:20
@damdo
Copy link
Member Author

damdo commented Apr 7, 2025

/test ?

@damdo
Copy link
Member Author

damdo commented Apr 7, 2025

/test e2e-aws-ovn-etcd-scaling e2e-aws-operator e2e-azure-ovn-etcd-scaling e2e-gcp-ovn-etcd-scaling

@damdo
Copy link
Member Author

damdo commented Apr 7, 2025

/test e2e-aws-ovn-etcd-scaling

@damdo
Copy link
Member Author

damdo commented Apr 7, 2025

/retest

@damdo
Copy link
Member Author

damdo commented Apr 7, 2025

/test e2e-aws-ovn-etcd-scaling

2 similar comments
@damdo
Copy link
Member Author

damdo commented Apr 8, 2025

/test e2e-aws-ovn-etcd-scaling

@damdo
Copy link
Member Author

damdo commented Apr 11, 2025

/test e2e-aws-ovn-etcd-scaling

@damdo
Copy link
Member Author

damdo commented Apr 11, 2025

/test e2e-gcp-ovn-etcd-scaling

@damdo
Copy link
Member Author

damdo commented Apr 11, 2025

/test e2e-azure-ovn-etcd-scaling

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Apr 15, 2025

Conceptually this makes sense to me to avoid rapid flicks of degraded/stable

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@damdo damdo mentioned this pull request Jul 22, 2025
Merged
@openshift-bot
Copy link

openshift-bot commented Jul 31, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2025
@RadekManak
Copy link
Contributor

RadekManak commented Aug 11, 2025

/retest

@damdo damdo mentioned this pull request Aug 12, 2025
Merged
@openshift-bot
Copy link

openshift-bot commented Sep 11, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 11, 2025
@damdo
Copy link
Member Author

damdo commented Sep 20, 2025

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 20, 2025
@damdo damdo force-pushed the add-unmanaged-grace-period-for-new-node branch from aa2e7c7 to 1e1cc7a Compare November 12, 2025 16:59
@damdo damdo mentioned this pull request Nov 21, 2025
Merged
@damdo damdo force-pushed the add-unmanaged-grace-period-for-new-node branch from 1e1cc7a to 2fb8400 Compare February 3, 2026 09:03
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2026
@damdo
Copy link
Member Author

damdo commented Feb 3, 2026

/test e2e-aws-ovn-etcd-scaling
/test e2e-gcp-ovn-etcd-scaling
/test e2e-azure-ovn-etcd-scaling

@damdo damdo mentioned this pull request Feb 3, 2026
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2026

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial aa2e7c7 link true /test e2e-aws-ovn-serial
ci/prow/regression-clusterinfra-aws-ipi-cpms-allcases aa2e7c7 link false /test regression-clusterinfra-aws-ipi-cpms-allcases
ci/prow/unit aa2e7c7 link true /test unit
ci/prow/e2e-gcp-ovn-etcd-scaling 2fb8400 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-etcd-scaling 2fb8400 link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling 2fb8400 link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damdo @JoelSpeed @openshift-bot @RadekManak