Implement ppl IN subquery command with Calcite
#3371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
LantaoJin
changed the title
IN subquery command with Calcite
penghuo
reviewed
Mar 3, 2025
| source = %s | fields uid, name | ||
| ] | ||
| | sort - salary | ||
| | fields id, name, salary |
There was a problem hiding this comment.
- what if subquery include less columns
source = %s | where (id, name) not in [source = %s | fields name] - or more columns,
source = %s | where (id, name) not in [source = %s | fields id, name, salary]
There was a problem hiding this comment.
Added more tests and convert the AssertError to SemanticCheckException @penghuo
Signed-off-by: Lantao Jin <ltjin@amazon.com>
penghuo
approved these changes
Mar 4, 2025
LantaoJin
merged commit a62d87d
into
opensearch-project:feature/calcite-engine
5 of 13 checks passed
7 tasks
penghuo
pushed a commit
to penghuo/os-sql
that referenced
this pull request
Mar 12, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core Syntax: Implement ppl
INsubquery command with Calcite./gradlew :integ-test:integTest --tests '*Calcite*IT'succeed in localExcepts
Those IT failed due to enable pushdown after merged #3366
Related Issues
Resolves #3359
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.