Enable push down optimization by default #3366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the previous implementation, we push down project/filter into
OpenSearchProjectIndexScanRulewithout any updating on itsdigest, which uniquely identifies a RelNode. This causes an equivalent issue with the nodes ofCalciteOpenSearchIndexScanand makes the different RelSets in the optimizer mess up inaccurately.This PR fixes this issue by overriding the
explainTermsmethod to reflectPushDownContextin its final computeddigest. And enable the push down by default in our settings, since all tests work fine the feature../gradlew :integ-test:integTest --tests '*Calcite*IT'succeed locally.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.