Skip to content

Separate build and validateAndBuild method in DataSourceMetadata #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ykmr1224 merged 1 commit into from
Jun 13, 2024
Merged

Separate build and validateAndBuild method in DataSourceMetadata #2744

ykmr1224 merged 1 commit into from
Jun 13, 2024

Conversation

@ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jun 12, 2024

Description

  • Separate build and validateAndBuild method in DataSourceMetadata to let internally build special DataSourceMetadata.
  • The validation doesn't allow datasource name starting from _(underscore)

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224 ykmr1224 added backport 2.x maintenance Improves code quality, but not the product labels Jun 12, 2024
@ykmr1224
Separate build and validateAndBuild method in DataSourceMetadata
6d7a20a 
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 force-pushed the dqs/datasource-validation branch from 5eaca2b to 6d7a20a Compare June 12, 2024 22:47
@ykmr1224 ykmr1224 marked this pull request as ready for review June 12, 2024 23:12
@noCharger
Copy link
Collaborator

noCharger commented Jun 12, 2024 •
edited
Loading

Separate build and validateAndBuild method in DataSourceMetadata to let internally build special DataSourceMetadata.

Is it feasible to apply different set of validation rules on another DataSourceMetadata implementation? (With or without this PR)

@ykmr1224
Copy link
Collaborator Author

ykmr1224 commented Jun 12, 2024

Separate build and validateAndBuild method in DataSourceMetadata to let internally build special DataSourceMetadata.

Is it feasible to apply different set of validation rules on another DataSourceMetadata implementation? (With or without this PR)

Any additional validation can be done when datasource is created.

@vamsimanohar
Copy link
Member

vamsimanohar commented Jun 13, 2024

What is the use case that is driving this change?

@ykmr1224
Copy link
Collaborator Author

ykmr1224 commented Jun 13, 2024

What is the use case that is driving this change?

When try to instantiate DataSourceMetadata with _xxxxx (starting from underscore), it was failing and we couldn't instantiate DataSourceMetadata with such special value.

@vamsimanohar
Copy link
Member

vamsimanohar commented Jun 13, 2024

What is the use case that is driving this change?

When try to instantiate DataSourceMetadata with _xxxxx (starting from underscore), it was failing and we couldn't instantiate DataSourceMetadata with such special value.

Is this for testing?

@ykmr1224 ykmr1224 merged commit 7b40c2c into opensearch-project:main Jun 13, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 13, 2024
@github-actions
Separate build and validateAndBuild method in DataSourceMetadata (#2744)
6b70ba9 
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 7b40c2c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 13, 2024
Merged
ykmr1224 pushed a commit that referenced this pull request Jun 25, 2024
@opensearch-trigger-bot @github-actions
Separate build and validateAndBuild method in DataSourceMetadata (#2744…
f273301 
…) (#2752)

(cherry picked from commit 7b40c2c)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
@ykmr1224 @jzonthemtn
Separate build and validateAndBuild method in DataSourceMetadata (ope…
2ee2e5a 
…nsearch-project#2744)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vamsimanohar vamsimanohar vamsimanohar approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

+1 more reviewer

@rupal-bq rupal-bq rupal-bq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x maintenance Improves code quality, but not the product

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ykmr1224 @noCharger @vamsimanohar @rupal-bq