Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster name in spark submit params #2467

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Jan 3, 2024

Description

Add cluster name in spark submit params

Issues Resolved

#2465

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (797276d) 95.40% compared to head (c9bb54d) 95.41%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2467   +/-   ##
=========================================
  Coverage     95.40%   95.41%           
  Complexity     5000     5000           
=========================================
  Files           479      479           
  Lines         13939    13950   +11     
  Branches        937      937           
=========================================
+ Hits          13299    13310   +11     
  Misses          618      618           
  Partials         22       22           
Flag Coverage Δ
sql-engine 95.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noCharger
Copy link
Collaborator Author

https://github.com/opensearch-project/sql/actions/runs/7402675720/job/20141020203?pr=2467

CI failed on an unrelated code path:Task :core:test

DateTimeFunctionTest > testWeekOfYearWithTimeType() FAILED
YearweekTest > testYearweekWithTimeType() FAILED

Create a issue to track the fix #2468

Signed-off-by: Louis Chu <clingzhi@amazon.com>
@vamsi-amazon
Copy link
Member

https://github.com/opensearch-project/sql/actions/runs/7402675720/job/20141020203?pr=2467

CI failed on an unrelated code path:Task :core:test

DateTimeFunctionTest > testWeekOfYearWithTimeType() FAILED YearweekTest > testYearweekWithTimeType() FAILED

Create a issue to track the fix #2468

Can we comment those and verify if the rest of the tests are working fine. Just to be sure the new code is not causing any regression.
You can comment them run CI and uncomment them back.

@noCharger
Copy link
Collaborator Author

noCharger commented Jan 5, 2024

Can we comment those and verify if the rest of the tests are working fine. Just to be sure the new code is not causing any regression.

@vamsi-amazon I don't think these failed UTs are related to the new code. It has causing CI failed for a while (for example it shown in previous PR https://github.com/opensearch-project/sql/actions/runs/7383460047/job/20084703703?pr=2464)

Also all CI tasks in spark component are succeeded.

> Task :spark:compileTestJava
Note: D:\a\sql\sql\spark\src\test\java\org\opensearch\sql\spark\asyncquery\AsyncQueryExecutorServiceSpec.java uses or overrides a deprecated API.

Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :spark:processTestResources
> Task :spark:testClasses
> Task :spark:junit4
> Task :spark:test
> Task :spark:jacocoTestReport
> Task :spark:jacocoTestCoverageVerification
> Task :spark:check
> Task :spark:build

@noCharger
Copy link
Collaborator Author

Thanks team for the review, can someone merge this PR?

@penghuo penghuo merged commit efb159a into opensearch-project:main Jan 8, 2024
17 of 23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 8, 2024
* Add cluster name in spark submit params

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Include cluster name to spark env

Signed-off-by: Louis Chu <clingzhi@amazon.com>

---------

Signed-off-by: Louis Chu <clingzhi@amazon.com>
(cherry picked from commit efb159a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Jan 25, 2024
* Add cluster name in spark submit params

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Include cluster name to spark env

Signed-off-by: Louis Chu <clingzhi@amazon.com>

---------

Signed-off-by: Louis Chu <clingzhi@amazon.com>
(cherry picked from commit efb159a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Feb 2, 2024
* Add cluster name in spark submit params



* Include cluster name to spark env



---------


(cherry picked from commit efb159a)

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@noCharger noCharger deleted the add-cluster-name branch February 12, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants