Added SIGNUM function to V2 engine #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells
changed the title
10 tasks
Yury-Fridlyand
previously approved these changes
Mar 15, 2023
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Yury-Fridlyand
previously approved these changes
Mar 15, 2023
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Yury-Fridlyand
approved these changes
Mar 15, 2023
dai-chen
approved these changes
Mar 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Added SIGNUM function to V2 engine (#241) * Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merge mistake Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merging error Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit 6496692)
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Added SIGNUM function to V2 engine (#241) * Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merge mistake Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merging error Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit 6496692) Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests
Issues Resolved
#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.