Added SIGNUM function to V2 engine #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Codecov Report
@@ Coverage Diff @@
## integ-signum #241 +/- ##
===============================================
Coverage 98.38% 98.38%
- Complexity 3698 3701 +3
===============================================
Files 343 343
Lines 9121 9126 +5
Branches 586 586
===============================================
+ Hits 8974 8979 +5
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GabeFernandez310
approved these changes
Mar 7, 2023
GumpacG
reviewed
Mar 8, 2023
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
GumpacG
approved these changes
Mar 8, 2023
|
Seems that there are doctests failing |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Yury-Fridlyand
approved these changes
Mar 8, 2023
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
|
Please, fix doctests |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells
changed the title
GabeFernandez310
approved these changes
Mar 9, 2023
Author
|
Doc tests have been fixed |
GabeFernandez310
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Added SIGNUM function to V2 engine (#241) * Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merge mistake Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merging error Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com>
MaxKsyunz
pushed a commit
that referenced
this pull request
Mar 29, 2023
…rch-project#1442) * Added SIGNUM function to V2 engine (#241) * Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merge mistake Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed merging error Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit 6496692) Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added math function SIGNUM to V2 engine, updated documentation, and added unit/IT tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.