Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test project_source_change_type_env should throw a SemanticCheckException #917

Open
GumpacG opened this issue Oct 14, 2022 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@GumpacG
Copy link
Collaborator

GumpacG commented Oct 14, 2022

What is the bug?
The test project_source_change_type_env does not throw a SemanticCheckException.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Run the test project_source_change_type_env in https://github.com/opensearch-project/sql/blob/2.x/core/src/test/java/org/opensearch/sql/analysis/AnalyzerTest.java
  2. See that a SemanticCheckException was expected to be thrown however, nothing was thrown.

What is the expected behavior?
The query source=schema | fields integer_value, double_value | fields float_value should throw a SemanticCheckException because the first fields already shrink the typeenv to {interger_value, double_value}

What is your host/environment?

  • OS: macOS
  • Version: OpenSearch 2.4
  • Plugins: OpenSearch SQL 2.x

Do you have any additional context?
Test should be enabled once this issue is resolved.

@GumpacG GumpacG added bug Something isn't working untriaged labels Oct 14, 2022
@DevPJ9
Copy link

DevPJ9 commented Oct 14, 2022

Hello, @GumpacG I would like to contribute.

@Yury-Fridlyand
Copy link
Collaborator

Hello, @GumpacG I would like to contribute.

@DevPJ9, you are welcome!

@DevPJ9
Copy link

DevPJ9 commented Oct 15, 2022

@Yury-Fridlyand can you please assign this to me.

@DevPJ9
Copy link

DevPJ9 commented Oct 20, 2022

Hello, @Yury-Fridlyand Sorry for the late reply. Can you please guide me through the steps to reproduce the error. I have not worked with "Test". Again, I am sorry for the late reply.

@Yury-Fridlyand
Copy link
Collaborator

@DevPJ9,
You can activate the test

@Disabled("the project/remove command should shrink the type env")
@Test
public void project_source_change_type_env() {
(delete @Disabled line)
and run it

./gradlew :core:test --tests org.opensearch.sql.analysis.AnalyzerTest.project_source_change_type_env

MaxKsyunz pushed a commit that referenced this issue Oct 28, 2022
- Enabled ignored and disabled tests.
- Created #922, #917, #912, #910 and attached them to disabled tests for traceability.
- Removed irrelevant tests.
@dai-chen dai-chen added infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. good first issue Good for newcomers labels Dec 14, 2022
@dai-chen
Copy link
Collaborator

@DevPJ9 you need any help on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

No branches or pull requests

5 participants