Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Test aggregation_cant_merge_indexScan_with_project fails #912

Open
GumpacG opened this issue Oct 13, 2022 · 0 comments
Open

[BUG] Test aggregation_cant_merge_indexScan_with_project fails #912

GumpacG opened this issue Oct 13, 2022 · 0 comments
Labels
bug Something isn't working infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@GumpacG
Copy link
Collaborator

GumpacG commented Oct 13, 2022

What is the bug?
The test aggregation_cant_merge_indexScan_with_project fails when it is enabled.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Run the test aggregation_cant_merge_indexScan_with_project in https://github.com/opensearch-project/sql/blob/2.x/opensearch/src/test/java/org/opensearch/sql/opensearch/planner/logical/OpenSearchLogicOptimizerTest.java
  2. See an AssertionFailedError with actual being OpenSearchLogicalIndexAgg(relationName=schema, filter==(intV, 1), aggregatorList=[AVG(intV)], groupByList=[longV], sortList=null)

What is the expected behavior?
Expected is LogicalAggregation(aggregatorList=[AVG(intV)], groupByList=[longV])

What is your host/environment?

  • OS: macOS
  • Version: OpenSearch 2.4.0
  • Plugins: OpenSearch SQL 2.x

Do you have any additional context?
The test should be enabled once this is fixed.
@GumpacG GumpacG added bug Something isn't working untriaged labels Oct 13, 2022
This was referenced Oct 17, 2022
Merged
Merged
MaxKsyunz pushed a commit that referenced this issue Oct 28, 2022
Enable ignored and disabled tests (#926)
3fd53ca 
- Enabled ignored and disabled tests.
- Created #922, #917, #912, #910 and attached them to disabled tests for traceability.
- Removed irrelevant tests.
@dai-chen dai-chen added v2.5.0 'Issues and PRs related to version v2.5.0' infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Dec 12, 2022
@dai-chen dai-chen removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GumpacG @dai-chen