Update usage of XContentFactory.xContent #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Member
|
Looks like CI failures are due to stale OS version in cache |
DarshitChanpura
requested changes
Feb 9, 2023
Member
DarshitChanpura
left a comment
DarshitChanpura
left a comment
There was a problem hiding this comment.
Needs change here too:
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Member
Author
|
Thank you @DarshitChanpura, I missed that instance. It is updated now. |
stephen-crawford
previously approved these changes
Feb 9, 2023
3 tasks
RyanL1997
previously approved these changes
Feb 9, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
dismissed stale reviews from RyanL1997, stephen-crawford, and DarshitChanpura
via
61d9a42
peternied
force-pushed
the
fix-main-ci-20230209
branch
from
61d9a42 to
05c82eb
Compare
peternied
approved these changes
Feb 14, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2433 +/- ##
============================================
- Coverage 61.25% 61.18% -0.08%
+ Complexity 3327 3322 -5
============================================
Files 260 260
Lines 18487 18487
Branches 3267 3267
============================================
- Hits 11325 11312 -13
- Misses 5570 5578 +8
- Partials 1592 1597 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DarshitChanpura
approved these changes
Feb 14, 2023
Closed
3 tasks
stephen-crawford
approved these changes
Feb 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Switch from XContentType to MediaType Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com> (cherry picked from commit bae002b)
stephen-crawford
pushed a commit
that referenced
this pull request
Feb 24, 2023
…f XContentFactory.xContent (#2451) * Update usage of XContentFactory.xContent (#2433) * Switch from XContentType to MediaType Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com> (cherry picked from commit bae002b) * Increment version to 2.7.0.0 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update bwcVersion Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update bwc_version in ci.yml Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Apr 27, 2023
* Switch from XContentType to MediaType Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XContentFactory.xContentchanged from.xContent(XContentType type)to.xContent(MediaType type)so the usage in the security plugin needs updated.PR in core where it was changed: https://github.com/opensearch-project/OpenSearch/pull/6218/files#diff-43443b6903e7fb18cd02e5ebb48c17f2168b75e9d31cf7e24a7df7d0d763c220L144-L145
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.