Skip to content

Conversation

@stephen-crawford
Copy link
Contributor

Signed-off-by: Stephen Crawford steecraw@amazon.com

Description

[Describe what this change achieves]
Updates Kafka dependency on 3.0.2 -> 3.4.0. Also updates three dependencies which had a conflict in the versions.

Issues Resolved

#2431

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@stephen-crawford stephen-crawford requested a review from a team February 9, 2023 20:32
@cwperks
Copy link
Member

cwperks commented Feb 9, 2023

The plugin-install is impacted by the issue addressed in this open PR: #2433

@stephen-crawford stephen-crawford force-pushed the Main-CVE-Fix branch 2 times, most recently from b966250 to ec43c19 Compare February 16, 2023 21:31
stephen-crawford and others added 3 commits February 16, 2023 16:32
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@stephen-crawford
Copy link
Contributor Author

So the CVE is addressed in Kafka version 3.4.0, but we use springframework.kafka for the KafkaSinkTest. However, the springframework.kafka versions only support up to Kafka 3.3.2 as of the new release today. Unfortunately, the CVE is still present in Kafka 3.3.2, so upgrading to that does not fix the issue. We will need to wait until there is an updated springframework.kafka version which support Kafka 3.4.0 before we can fix the CVE.

The CVE is based around de-serializing LDAP responses by connecting to an attacker's LDAP server so it is not clear that OpenSearch would directly be impacted by the vulnerability.

@DarshitChanpura
Copy link
Member

@scrawfor99 This question spring-projects/spring-kafka#2574 mentions that the latest version (3.0.3) can be used for kafka 3.4.0.
Our test failures: java.lang.NoClassDefFoundError: kafka/common/KafkaException are due to version mismatch between spring and kafka dependencies.
I believe updating to kafka 3.0.3 should solve the issue.

@peternied
Copy link
Member

@scrawfor99 Looks like there is another pull request from a community member. If they sign the DCO would you want to close out this pull request and work with them on that PR?

@stephen-crawford
Copy link
Contributor Author

Hi @peternied, I am definitely in favor of the other contributor's PR.

I will leave a note @DarshitChanpura. I know it is from the version mismatch but on the website, it looked like it only supported up to 3.3.2. That being said, I see that the question you linked suggests otherwise. I will look at the workaround when helping the other contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants