Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jackson-databind and jackson-annotations dependency now coming from core #2325

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Dec 12, 2022

Signed-off-by: Craig Perkins cwperx@amazon.com

Description

jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars.

PR in core where the dependencies are added: opensearch-project/OpenSearch#5366

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Issues Resolved

#2324

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented Dec 12, 2022

CI won't pass until new artifacts are available for core. The distribution build for 3.0.0 has not succeeded since November 15.

@peternied
Copy link
Member

CI won't pass until new artifacts are available for core. The distribution build for 3.0.0 has not succeeded since November 15.

Can you create an issue on this?

….apache.kafka:kafka-storage

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #2325 (a14cbb7) into main (a368021) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2325      +/-   ##
============================================
- Coverage     61.09%   61.03%   -0.06%     
+ Complexity     3271     3267       -4     
============================================
  Files           260      260              
  Lines         18363    18369       +6     
  Branches       3250     3251       +1     
============================================
- Hits          11219    11212       -7     
- Misses         5559     5566       +7     
- Partials       1585     1591       +6     
Impacted Files Coverage Δ
...ch/security/auditlog/routing/AsyncStoragePool.java 50.00% <0.00%> (-5.56%) ⬇️
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...ensearch/security/compliance/ComplianceConfig.java 83.33% <0.00%> (-1.39%) ⬇️
...search/security/transport/SecurityInterceptor.java 75.38% <0.00%> (-0.77%) ⬇️
...security/dlic/rest/api/InternalUsersApiAction.java 83.78% <0.00%> (+1.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@peternied peternied merged commit ff798dd into opensearch-project:main Dec 13, 2022
This was referenced Dec 13, 2022
@cwperks cwperks added the backport 2.x backport to 2.x branch label Dec 13, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 13, 2022
… from core (#2325)

* Remove jackson-databind dependency now coming from core

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit ff798dd)
cwperks pushed a commit that referenced this pull request Dec 21, 2022
… from core (#2325) (#2343)

* Remove jackson-databind dependency now coming from core

Signed-off-by: Craig Perkins <cwperx@amazon.com>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
… from core (opensearch-project#2325) (opensearch-project#2343)

* Remove jackson-databind dependency now coming from core

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants